docs(dynamic-tester): docker_templates are reference-only; de-version inventory rows - #363
Merged
Merged
Conversation
… inventory rows The template Dockerfiles are documentation, not the runtime: the executed Dockerfile is LLM-generated per finding, the only prompt-pinned base image is Go (test_generator.py), Python/Node bases are chosen per generation, and the attacker sidecar image is inlined in docker_executor.py. Version tags in the inventory table had drifted three ways (README vs templates vs prompt) because renovate bumps the inert templates but can never touch prose or the prompt string — remove the tags so the rows cannot drift again, and state the file roles explicitly so future reviews do not reason about test runtimes from these files.
gadievron
requested review from
dgeyshis,
shahar-davidson and
sounil
as code owners
August 27, 2026 17:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
docker_templates/*.Dockerfileinventory rows as documentation only and removes their version tagsgeneration["dockerfile"]indocker_executor.py); the only prompt-pinned base image is Go (test_generator.py); Python/Node bases are chosen per generation; the attacker sidecar image is inlined indocker_executor.pyWhy
The version tags had drifted three ways (README: node:20/golang:1.22; templates: node:24/golang:1.27; prompt: golang:1.25) because renovate bumps the inert templates but can never touch prose or the prompt string — a sync sweep would rot on the next bump. De-versioning makes the rows drift-proof; the note prevents the actual failure mode, which has already occurred once (a review reasoned about test runtimes from the templates — see #351's correction comment).
Docs-only change; no code paths affected.