Skip to content

Conversation

@knative-automation
Copy link
Contributor

fix controller metrics crash -dprotaso

/cc knative/func-approvers
/assign knative/func-approvers

Produced by: knative-extensions/knobots/actions/update-deps

@knative-prow
Copy link

knative-prow bot commented Oct 22, 2025

@knative-automation: GitHub didn't allow me to request PR reviews from the following users: knative/func-approvers.

Note that only knative members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

fix controller metrics crash -dprotaso

/cc knative/func-approvers
/assign knative/func-approvers

Produced by: knative-extensions/knobots/actions/update-deps

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 22, 2025
@codecov
Copy link

codecov bot commented Oct 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.74%. Comparing base (2988acf) to head (2ada582).
⚠️ Report is 1 commits behind head on release-1.19.

Additional details and impacted files
@@                Coverage Diff                @@
##           release-1.19    #3131       +/-   ##
=================================================
+ Coverage         46.40%   59.74%   +13.34%     
=================================================
  Files               130      132        +2     
  Lines             16870    16879        +9     
=================================================
+ Hits               7828    10085     +2257     
+ Misses             8337     5837     -2500     
- Partials            705      957      +252     
Flag Coverage Δ
e2e-tests 41.14% <ø> (?)
integration-tests 54.47% <ø> (?)
unit-tests 46.66% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

bumping knative.dev/hack af735b2...50b120a:
  > 50b120a bump gotestfmt to newest version (# 449)
  > f2be520 [release-1.19] 🐛 Fix knative.dev/toolbox for older versions of Golang (# 444)
bumping knative.dev/networking 042b64d...7dad473:
  > 7dad473 upgrade to latest dependencies (# 1080)
bumping knative.dev/serving 0b07b19...634af56:
  > 634af56 upgrade to latest dependencies (# 16084)
  > a1a6407 [release-1.19] Serving Metric Tweaks (# 16063)
bumping knative.dev/eventing 931f60b...f53c251:
  > f53c251 [release-1.19] fix typo [skip-dot-release] (# 8743)
  > 5e02349 [release-1.19] Upgrade to latest dependencies (# 8720)
  > 49edf43 [release-1.19] Fix mt-broker-ingress auth to work with structured event too (# 8713)
bumping knative.dev/client/pkg 62fdfbf...0206e6c:
  > 0206e6c upgrade to latest dependencies (# 2053)
bumping knative.dev/pkg 077dcf0...4ebd86b:
  > 4ebd86b upgrade to latest dependencies (# 3282)
  > 7da1174 upgrade to latest dependencies (# 3281)
  > 2be9d56 Lock before iterating map so that code does not panic on concurrent write (# 3279)

Signed-off-by: Knative Automation <[email protected]>
@knative-automation knative-automation force-pushed the auto-updates/update-deps-release-1.19 branch from 6c345b4 to 2ada582 Compare October 22, 2025 16:31
Copy link
Contributor

@gauron99 gauron99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 22, 2025
@knative-prow
Copy link

knative-prow bot commented Oct 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauron99, knative-automation

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 22, 2025
@dprotaso
Copy link
Member

/retest

@knative-prow knative-prow bot merged commit 0e227dd into knative:release-1.19 Oct 23, 2025
35 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. skip-review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants