Skip to content

Conversation

matejvasek
Copy link
Contributor

@matejvasek matejvasek commented Oct 22, 2025

Changes

OCI pusher employs in-cluster-dialer, so it can push images to private in cluster OCI registries.

/kind bug

fix: host builder can push images to cluster internal registries

@matejvasek matejvasek requested a review from lkingland October 22, 2025 15:19
@knative-prow
Copy link

knative-prow bot commented Oct 22, 2025

@matejvasek: The label(s) kind/but cannot be applied, because the repository doesn't have them.

In response to this:

Changes

OCI pusher employs in-cluster-dialer, so it can push images to private in cluster OCI registries.

/kind but

fix: host builder can push images to cluster internal registries

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 22, 2025
@matejvasek matejvasek requested review from gauron99 and removed request for dsimansk and jrangelramos October 22, 2025 15:20
@matejvasek matejvasek added the kind/bug Categorizes issue or PR as related to a bug. label Oct 22, 2025
@gauron99
Copy link
Contributor

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 22, 2025
@knative-prow
Copy link

knative-prow bot commented Oct 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauron99, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [gauron99,matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Oct 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.06%. Comparing base (6f467c8) to head (6ac2ed0).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3130      +/-   ##
==========================================
+ Coverage   58.32%   59.06%   +0.73%     
==========================================
  Files         134      134              
  Lines       17369    17369              
==========================================
+ Hits        10131    10259     +128     
+ Misses       6300     6144     -156     
- Partials      938      966      +28     
Flag Coverage Δ
e2e-tests 40.29% <85.71%> (+1.37%) ⬆️
integration-tests 53.89% <42.85%> (+1.62%) ⬆️
unit-tests 46.20% <42.85%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants