-
Notifications
You must be signed in to change notification settings - Fork 164
feat(cmd): handle ErrEnvNotExist with typed error checking #3126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(cmd): handle ErrEnvNotExist with typed error checking #3126
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: intojhanurag The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @intojhanurag. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3126 +/- ##
==========================================
+ Coverage 58.32% 60.21% +1.88%
==========================================
Files 134 134
Lines 17369 13501 -3868
==========================================
- Hits 10131 8130 -2001
+ Misses 6300 4404 -1896
- Partials 938 967 +29
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hey @gauron99 , It is ready for review. |
| t.Fatalf("Expected no envs to remain, got '%v'", f.Run.Envs) | ||
| } | ||
|
|
||
| // TODO: create and test typed errors for ErrEnvNotExist etc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is a "etc" so I assume we need to do this for more errors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can add , but how will I know which ones are missing? Otherwise, I can keep this comment so that we can add more in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah lets add that comment back just in case, thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done !
Changes
ErrEnvNotExistto clearly indicate missing environment variables.errors.Asto assert that the correct typed error is returned.Namefield inErrEnvNotExistmatches the expected missing environment variable.