-
Couldn't load subscription status.
- Fork 164
feat(describe): prompt user when no function name provided #3092
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @intojhanurag. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: intojhanurag The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3092 +/- ##
===========================================
- Coverage 58.41% 30.89% -27.53%
===========================================
Files 134 117 -17
Lines 17263 16790 -473
===========================================
- Hits 10085 5187 -4898
- Misses 6246 10983 +4737
+ Partials 932 620 -312
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/ok-to-test |
7c23df9 to
aa2e71e
Compare
|
Hey @gauron99, I’m just curious, why is it asking for the function name even when no prompt was declared? |
|
not sure if I entirely understand what youre saying, but when you run So this test addition you implemented is only 50% of the intended change, you still need the actual implementation itself 😄 |
|
Thanks @gauron99 , I was a bit confused earlier. |
aa2e71e to
0cdd5cd
Compare
|
/retest |
|
@intojhanurag: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This PR enhances the func describe command by adding an interactive prompt that asks the user to enter a function name when it is not provided as a command argument.
Before
After