Skip to content

feat: improved error on remote deploy without local source #2885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lkingland
Copy link
Member

Give a more informative error when attempting to run a func deploy --remote --git-url=x that we still need local source.

This is needed because, conceptually local source would not be required for this case, but we need to update the remote build pipeline flow to check out the code on-demand in order for it to read metadata (like function name). For now, this code flow expects the source code to be available locally.

/kind enhancement

Copy link

knative-prow bot commented Jun 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lkingland

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 24, 2025
Copy link

codecov bot commented Jun 24, 2025

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 62.53%. Comparing base (1cccfd3) to head (5b18733).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
cmd/deploy.go 0.00% 10 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2885      +/-   ##
==========================================
+ Coverage   57.96%   62.53%   +4.56%     
==========================================
  Files         129      129              
  Lines       15767    15851      +84     
==========================================
+ Hits         9140     9912     +772     
+ Misses       5785     4996     -789     
- Partials      842      943     +101     
Flag Coverage Δ
e2e-tests 43.06% <0.00%> (+7.87%) ⬆️
integration-tests 48.73% <0.00%> (?)
unit-tests 48.85% <0.00%> (-0.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lkingland lkingland force-pushed the push-mszqtynupxor branch from 2d0ed56 to daf354a Compare June 26, 2025 03:27
@lkingland lkingland force-pushed the push-mszqtynupxor branch from daf354a to 5b18733 Compare June 26, 2025 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/enhancement size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant