Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.17] Add sinks.knative.dev to namespaced ClusterRole #8433

Open
wants to merge 1 commit into
base: release-1.17
Choose a base branch
from
Open

[release-1.17] Add sinks.knative.dev to namespaced ClusterRole #8433

wants to merge 1 commit into from
+15 −2

Conversation

knative-prow-robot
Copy link
Contributor

This is an automated cherry-pick of #8432

Add `sinks.knative.dev` to namespaced ClusterRoles

@pierDipi @knative-prow-robot
Add sinks.knative.dev to namespaced ClusterRole
a8f2cb3 
These are roles that users can use to give their developers access
to Knative Eventing resources and we're missing the sinks group.

Signed-off-by: Pierangelo Di Pilato <[email protected]>
@knative-prow-robot knative-prow-robot mentioned this pull request Jan 30, 2025
Merged
5 tasks
@knative-prow knative-prow bot requested review from Leo6Leo and pierDipi January 30, 2025 16:39
@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 30, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.10%. Comparing base (4542e6b) to head (a8f2cb3).

Additional details and impacted files 
@@              Coverage Diff              @@
##           release-1.17    #8433   +/-   ##
=============================================
  Coverage         64.10%   64.10%           
=============================================
  Files               388      388           
  Lines             23363    23363           
=============================================
  Hits              14976    14976           
  Misses             7591     7591           
  Partials            796      796

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knative-prow Knative Prow
Copy link

knative-prow bot commented Jan 30, 2025

@knative-prow-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
reconciler-tests_eventing_release-1.17 a8f2cb3 link true /test reconciler-tests

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

pierDipi
pierDipi approved these changes Jan 31, 2025
View reviewed changes
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 31, 2025
@knative-prow Knative Prow
Copy link

knative-prow bot commented Jan 31, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knative-prow-robot, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 31, 2025
@pierDipi
Copy link
Member

/test reconciler-tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierDipi pierDipi pierDipi approved these changes

@Leo6Leo Leo6Leo Awaiting requested review from Leo6Leo

Assignees

@pierDipi pierDipi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@knative-prow-robot @pierDipi