Skip to content

Conversation

@iRaindrop
Copy link
Contributor

The overview of configuration tasks should parallell the Navigation.

Proposed Changes

  • Reformatted listing
  • Added mermaid graphic for testing

Added mermaid graphic and content formatting testing
@netlify
Copy link

netlify bot commented Oct 30, 2025

Deploy Preview for knative failed.

Built without sensitive environment variables

Name Link
🔨 Latest commit efa3f03
🔍 Latest deploy log https://app.netlify.com/projects/knative/deploys/6904d1429a40b70008c72c17

@knative-prow knative-prow bot requested review from nainaz and skonto October 30, 2025 18:42
@knative-prow
Copy link

knative-prow bot commented Oct 30, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: iRaindrop
Once this PR has been reviewed and has the lgtm label, please assign houshengbo for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 30, 2025
@iRaindrop iRaindrop marked this pull request as draft October 30, 2025 18:43
@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 30, 2025
Comment on lines 12 to 19
```mermaid
---
config:
theme: redux
---
flowchart TD
A(["Administrator"]) --> B{"Knative"}
B --> C["Knative Serving"] & D["Knative Eventing"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't exactly match what I was imagining for the "duck analogy" (which doesn't seem to show up in the text).

I was thinking of something more like:

Suggested change
```mermaid
---
config:
theme: redux
---
flowchart TD
A(["Administrator"]) --> B{"Knative"}
B --> C["Knative Serving"] & D["Knative Eventing"]
```mermaid
---
config:
theme: redux
---
flowchart TD
Dev(["Application Developers"])
dev-acts@{ shape: text, label: "Manages k8s objects defined by" }
subgraph Knative
Serving
Eventing
end
subgraph Plugins
net-istio["Istio"]
net-contour["Contour"]
net-gateway-api["Gateway API"]
event-kafka["Kafka"]
event-rabbitmq["RabbitMQ"]
event-nats["NATS"]
end
event-impl@{ shape: text, label: "implements" }
net-impl@{ shape: text, label: "implements" }
admin-acts@{ shape: text, label: "Installs and configures" }
Admin(["Cluster Administrators"])
Dev --- dev-acts
dev-acts --> Serving & Eventing
admin-acts --- Admin
Plugins & Knative --- admin-acts
%% The ~~~ ... --> syntax is used to force backwards arrows;
%% See https://github.com/mermaid-js/mermaid/issues/2629 for details.
Serving ~~~ net-impl --> Serving
Eventing ~~~ event-impl --> Eventing
net-impl --- net-istio & net-contour & net-gateway-api
event-impl --- event-kafka & event-rabbitmq & event-nats

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the links around event-impl and net-impl, you might want to use the -.- or -.-> syntax to make the lines dotted rather than solid

Copy link
Contributor Author

@iRaindrop iRaindrop Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - That was just a placeholder -- looks great

Knative uses Kubernetes YAML manifests to define and configure system components. These manifests include core resources, custom resource definitions (CRDs), and extensibility features. As with Kubernetes, these configuration resources are declarative and can be managed using the `kubectl` CLI tool or with continuous delivery tools.

### Resource scoping and namespaces
The following sections provide an overview of the current configurations procedures of interest to Administrators.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still not entirely sold on duplicating the navigation in prose here. I realize that it's tempting to have a little more explanation than what's in the titles in the left-hand navigation, but I have a maintenance concern that duplicating the navigation here will cause the two to drift out of sync over time.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, even thought it's at the node level. The Eventing config overviews fell nicely into a table, I can redo for Serving and Network Options into a table.

@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 31, 2025
Added Eventing config summaries
Put all config overviews in tables
Section title tweaks
Formatting edits
Organized sections
Formatting test
Removed temporary test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants