-
Notifications
You must be signed in to change notification settings - Fork 1.3k
drop port forwarding #6444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
drop port forwarding #6444
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for knative ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
this simplifies client interaction as we don't require port-fowarding anymore
52b1140 to
fe2efe6
Compare
code-samples/eventing/bookstore-sample-app/start/frontend/config/100-front-end-deployment.yaml
Outdated
Show resolved
Hide resolved
|
re-opened so we get the github rate limit fix in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't finished it yet. Submitting for the first round of review.
code-samples/eventing/bookstore-sample-app/start/slack-sink/application.properties
Outdated
Show resolved
Hide resolved
…plication.properties Co-authored-by: Leo Li <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have finished most of the review, beside these comments, the rest looks good. I will be manually follow and run through the tutorial later to make sure content is accurate. Thanks @dprotaso !
|
bump @Leo6Leo |
|
The registry route should be updated to dynamic, and use the one that's being provided by the user input. Also the |
Want do make those changes in a follow up? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have successfully had the bookstore running up and working locally with all the new changes. Besides my 2 comments there, the rest looks good to me! Thanks @dprotaso
|
|
||
| # Deploy the ML services | ||
| echo "" | ||
| echo "📦 Deploying the ML service: bad-word-filter..." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
export DOCKER_HOST=unix://$HOME/.docker/run/docker.sock is needed for me when using local KinD cluster. Otherwise, the following error prompt:
📦 Deploying the ML service: bad-word-filter...
Building function image
Error: cannot create docker client: docker/podman API not available
Possible causes:
The docker/podman daemon is not running.
The DOCKER_HOST environment variable is not set.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
export DOCKER_HOST=unix://$HOME/.docker/run/docker.sock
That's not universal so I don't think we should tell people to do that. A requirement beforehand should be a 'working docker'
I'm hoping this supplements #6204