Skip to content

Add skip permissions option to ApiServerSource #6288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 22, 2025
Merged

Add skip permissions option to ApiServerSource #6288

merged 3 commits into from
Jul 22, 2025

Conversation

rh-hemartin
Copy link
Contributor

"Fixes #issue-number" or "Add description of the problem this PR solves"

Related to knative/eventing#8615

Proposed Changes

  • Add feature page for ApiServerSource, I was not sure where to add it.

@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 7, 2025
@knative-prow knative-prow bot requested review from mmejia02 and pierDipi July 7, 2025 07:22
@netlify Netlify
Copy link

netlify bot commented Jul 7, 2025 •
edited
Loading

✅ Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit b91db0f
🔍 Latest deploy log https://app.netlify.com/projects/knative/deploys/687f268fe7f01a0008986226
😎 Deploy Preview https://deploy-preview-6288--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 7, 2025
@rh-hemartin rh-hemartin mentioned this pull request Jul 7, 2025
Merged
5 tasks
@rh-hemartin
Rename annotation
92f660c 
Signed-off-by: Hector Martinez <[email protected]>
@rh-hemartin rh-hemartin marked this pull request as ready for review July 21, 2025 13:36
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 21, 2025
@knative-prow knative-prow bot requested a review from nainaz July 21, 2025 13:36
creydr
creydr suggested changes Jul 21, 2025
View reviewed changes
docs/eventing/sources/apiserversource/features.md Outdated
When the ApiServerSource resource is changed, Knative Eventing checks that it has the required
permissions for the resources and namespaces defined before updating the ApiServerSource Deployment.
On large clusters checking for permissions can put pressure on the Kubernetes API leading to
resource pressure. To make the ApiServerSource skip permissions set the following annotation:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
resource pressure. To make the ApiServerSource skip permissions set the following annotation:
resource pressure. To make the ApiServerSource skip permission checks set the following annotation:

docs/eventing/sources/apiserversource/features.md Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd put this as a separate chapter under in the reference.md file. So the user has everything together. When the feature list gets too big, we could think about having it as a separate page, but as long as we have only a small number of features, I'd keep it for visibility on the "main" configuration page (IMO)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the place, let me know what you think

@rh-hemartin
Move page to reference.md
b91db0f 
Signed-off-by: Hector Martinez <[email protected]>
@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 22, 2025
creydr
creydr approved these changes Jul 22, 2025
View reviewed changes
Copy link
Member

@creydr creydr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rh-hemartin for updating the docs on this!

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 22, 2025
@knative-prow Knative Prow
Copy link

knative-prow bot commented Jul 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, rh-hemartin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 22, 2025
@knative-prow knative-prow bot merged commit 59fd9a0 into knative:main Jul 22, 2025
19 checks passed
@rh-hemartin rh-hemartin deleted the skip-permissions branch July 22, 2025 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@creydr creydr creydr approved these changes

@mmejia02 mmejia02 Awaiting requested review from mmejia02

@pierDipi pierDipi Awaiting requested review from pierDipi

@nainaz nainaz Awaiting requested review from nainaz

Assignees

@creydr creydr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rh-hemartin @creydr