fix: strengthen learning validity across orchestrator and S1-S7 - #5
Merged
Conversation
kms9
marked this pull request as ready for review
August 5, 2026 00:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
目标
按本轮评审修复总控与七阶段 Skill,使流程不再只保证“状态机完整”,同时机械约束诊断效度、确认语义、真实/模拟证据隔离、迁移保持和模型持久化。
核心变更
confirmed_fields/unconfirmed_fields,最终验收包含未见任务、迁移和适用的保持。sub-item → indicator → node;记录minimum_observations。synthetic_learner_behavior,阻止真实项目引用simulations/**,检查八个 Skill 的关键规则。workspace/AGENTS.md,修复此前全仓 validator 的共享文件缺失。预期验证
python3 scripts/validate_delivery_contract.pypython3 scripts/validate_delivery_contract.py --project-dir workspace/forward-deployed-engineer注意
当前分支保留既有 simulations 夹具作为非门控历史;新合同要求新的 fixture 使用
synthetic_learner_behavior,并由 validator 阻止其进入真实项目状态。