Cleanup left over test files

[hzxuzhonghu]

Fix #91

[kmesh-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from hzxuzhonghu. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[gemini-code-assist]

Summary of Changes

Hello @hzxuzhonghu, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on improving the cleanliness and maintainability of the repository by addressing the generation and persistence of temporary files. It streamlines the testing process by ensuring that test-generated artifacts are properly cleaned up and enhances the development environment by ignoring unnecessary IDE and OS-specific files from version control.

Highlights

• Test Artifact Cleanup: Removed code responsible for writing temporary serialized YAML configuration files to disk during testing in orion-configuration/src/config.rs.
• Test File Management: Ensured that the /tmp/test-access.log file created during orion-lib/src/access_log.rs tests is explicitly removed after the test run.
• Version Control Ignores: Updated the .gitignore file to include common IDE and operating system specific files, namely .vscode and .DS_Store, preventing them from being tracked by Git.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Warning

Gemini encountered an error creating the review. You can try again by commenting /gemini review.

[Eeshu-Yadav]

#85 this is with another apporach as told to add it under temp directory

[hzxuzhonghu]

@Eeshu-Yadav I donot see how the new files is needed

[Eeshu-Yadav]

In the issue description I have asked that what to do with these files , then I add those under the temp, will close that issue

@Eeshu-Yadav I donot see how the new files is needed

[hzxuzhonghu]

IIRC, these files seems not compared, can remove

[hzxuzhonghu]

@dawid-nowak Can you explain wht these temp files needed

[dawid-nowak]

The way i see, during the tests there are some test-config files created in ./orion-proxy/conf/ ... and left there after the test. They are not belonging to git and git will show them as untracked which is confusing and these files pollute the project space. So changing the location to /tmp for those auto generated files makes sense.

[hzxuzhonghu]

I mean why we need to generate temp files, we can remove ths snippet if not needed

[dawid-nowak]

I mean why we need to generate temp files, we can remove ths snippet if not needed

I think using /tmp is safer.. no need to populate the project space with extra files and no need to removing files individually. You can remove all artifacts in one go.