Updating all dependencies #130
Conversation
Summary of ChangesHello @dawid-nowak, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a comprehensive update of all project dependencies to their most recent versions. The primary goal is to leverage the latest features, performance improvements, and security fixes offered by updated libraries. This involved modifying Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates a large number of dependencies to their latest versions. This is a valuable maintenance task that keeps the project up-to-date with security patches and new features. The changes also include necessary code adaptations for breaking changes in the updated dependencies, particularly around tonic and exponential-backoff. My review focuses on ensuring these adaptations are correct and don't introduce new issues. I've identified a few areas for improvement, including removing leftover debug code, clarifying a change in default features, and addressing a potential logic issue in the retry mechanism. Overall, this is a good step forward for the project's health.
|
|
||
| let mut total_requests = 0; | ||
| for (index, back_off) in retry_policy.exponential_back_off().iter().enumerate() { | ||
| let back_off = back_off.unwrap_or_default(); |
There was a problem hiding this comment.
Using unwrap_or_default() here will result in a Duration of zero if back_off is None. This means the retry would happen immediately without any delay. This could lead to hammering a service. Is this the intended behavior? If None indicates a specific condition (like disabled jitter), it might be better to fall back to a base delay instead of zero.
envoy-data-plane-api/build.rs
Outdated
| let path = env::current_dir()?; | ||
| println!("The current directory is {}", path.display()); |
There was a problem hiding this comment.
This println! statement and the current directory retrieval appear to be for debugging purposes. They should be removed from the final code to avoid printing to stdout during every build and performing unnecessary operations.
orion-lib/Cargo.toml
Outdated
| # making sure we are not using pure ring | ||
| aws_lc_rs = ["rustls/aws_lc_rs"] | ||
| default = ["aws_lc_rs"] | ||
| default = ["aws_lc_rs","metrics"] |
There was a problem hiding this comment.
The metrics feature has been added to the default features. This is a significant change as it will enable metrics by default for this crate. Please ensure this is the intended behavior and consider documenting this change in the crate's release notes or README.
Signed-off-by: Dawid Nowak <[email protected]>
dawid-nowak
force-pushed
the
dawid.nowak/dependency_bump
branch
from
9a2602b to
ac9f55e
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hzxuzhonghu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Updating dependencies to latest and greatest...
Also see issue #129, which needs to be solved separately.