Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SharpLab fixes: Wave 3 #13

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

ashmind
Copy link
Contributor

@ashmind ashmind commented Oct 21, 2021

Unfortunately these are quite hard to disentangle into separate branches, so I had to create it as a single PR.
On the positive side, this time it has tests.

Summary of changes:

  1. Resolved issue with error location being outside of the bounds of the document in certain cases (when near end of file)
  2. Corrected top-level duplicate methods to be reported as an error instead of an (unintended) exception
  3. Corrected duplicate fields to be reported as an error instead of an (unintended) exception
  4. Added a way to override direct filesystem access when referencing a manifest resource (potential security concern for Web Applications)
  5. Some refactoring to allow 4, e.g. added a DriverSettings class

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant