Modernizing the library a bit #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renamed License to .txt Add Git ignore Add .npmignore and add a circleci config Add Contributing Document. update Readme
alisonaquinas
commented
Nov 4, 2023
| node_modules | ||
| package-lock.json | ||
| test-results.xml | ||
| test |
There was a problem hiding this comment.
This keeps the tests out of the published package, making the published package smaller
alisonaquinas
commented
Nov 4, 2023
| @@ -1,12 +1,16 @@ | |||
| # UTF-7 | |||
|
|
|||
| [](https://circleci.com/gh/kkaefer/utf7) | |||
| [](https://circleci.com/gh/kkaefer/utf7) [](https://www.npmjs.com/package/utf7) | |||
There was a problem hiding this comment.
Added a badge for your NPM package
alisonaquinas
commented
Nov 4, 2023
|
|
||
| Encodes and decodes JavaScript (Unicode/UCS-2) strings to UTF-7 ASCII strings. It supports two modes: UTF-7 as defined in [RFC 2152](http://tools.ietf.org/html/rfc2152) and Modified UTF-7 as defined by the IMAP standard in [RFC 3501, section 5.1.3](http://tools.ietf.org/html/rfc3501#section-5.1.3) | ||
|
|
||
| ## Usage | ||
|
|
||
| **RFC 2152** |
There was a problem hiding this comment.
Markdown linters prefer using headers over emphasis here
alisonaquinas
commented
Nov 4, 2023
| "scripts": { | ||
| "test": "tape test/*.js" | ||
| } | ||
| "test": "tape test/*.js | tap-xunit > test-results.xml" |
There was a problem hiding this comment.
This change allows circle CI to parse the uni test results
|
@alisonaquinas Have you been able to get ahold of Konstantin? even just changing a single character in the package.json (~ to a ^) would be enough to get npm update to allow semver |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, Konstantin; thank you for getting back to me, I appreciate it. I've got this broken up into two commits, I won't be offended if you pick and choose; I just wanted to share the work I already did.