Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Baofeng UV-21Pro v2 #1167

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions chirp/drivers/baofeng_uv17Pro.py
Original file line number Diff line number Diff line change
Expand Up @@ -1575,3 +1575,19 @@ class UV5RH(UV17Pro):
LIST_PW_SAVEMODE = ["Off", "1:1", "1:2", "1:4"]
MODES = UV17Pro.MODES + ['AM']
_has_workmode_support = True


@directory.register
class UV21ProV2(UV17Pro):
VENDOR = "Baofeng"
MODEL = "UV-21Pro-v2"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should just say UV-21Pro here. Since the bug you reference doesn't mention V2 but says that the existing UV-17Pro driver works, I think your concern over V1/V2 probably means that your driver will work for both. So yes, please also add the Fixes: tag to link/close that bug.

Also, I haven't eye-diffed this, but is this actually different from any of the above models? If so, then this looks okay, but if not, I think I'd prefer to just add an entry to the model_alias_map. There are so many total clones of the UV-17 that this file is starting to get littered with them :)

Thanks!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hard for me to say if this differs from other models as I don't have access to all of them to test. In https://chirpmyradio.com/issues/10581 it is suggested to use the Baofeng UV-17Pro profile with the UV-21, however the UV-17Pro profile doesn't seem to support airband.
An alternative path to fix this would be to add airband to the UV-17Pro profile (which seems to support airband according to the specs I found online) and see whether it works with both UV-17Pro and UV-21; however in that case I would not be able to test with the UV-17Pro.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay so this looks identical to the above 5RH model with the exception of the power levels. Does the UV21 really only have hi/lo?

At the very least, please subclass that and just override the POWER_LEVELS bit so it's clear that it's otherwise identical.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also looks maybe identical to the 17RPlus?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, the UV-17R-Plus profile seems to do the trick.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So should we replace this with just an update to chirp/share/model_alias_map.yaml ?


VALID_BANDS = [UV17Pro._airband, UV17Pro._vhf_range, UV17Pro._vhf2_range,
UV17Pro._uhf_range, UV17Pro._uhf2_range]
POWER_LEVELS = [chirp_common.PowerLevel("High", watts=10.00),
chirp_common.PowerLevel("Low", watts=2.00)]
SCODE_LIST = ["%s" % x for x in range(1, 16)]
SQUELCH_LIST = ["Off"] + list("123456789")
LIST_PW_SAVEMODE = ["Off", "1:1", "1:2", "1:4"]
MODES = UV17Pro.MODES + ['AM']
_has_workmode_support = True
Binary file added tests/images/Baofeng_UV-21Pro_v2.img
Binary file not shown.