cmd/recordexec: Also save proposed blocks to filesystem#1
Draft
hi-im-milan wants to merge 1 commit intokjcamann:ken/event-recovery-new-event-sourcefrom
Draft
cmd/recordexec: Also save proposed blocks to filesystem#1hi-im-milan wants to merge 1 commit intokjcamann:ken/event-recovery-new-event-sourcefrom
hi-im-milan wants to merge 1 commit intokjcamann:ken/event-recovery-new-event-sourcefrom
Conversation
We can dump all the proposed blocks to the filesystem in `proposals` subdir and once they get finalised - simply move them to the correct archive directory. Benefit of this approach is that applications ingesting monad events can rely completely on the filesystem operations (including inotify) to detect new blocks, without waiting for block to be verified. This is a RFC commit, there are things that need to be cleaned up + it hasn't been tested. I think this approach shouldn't add much overhead, unless we are expecting to have lot of blocks which are proposed but not verified. rename(2) should be pretty much an instant operation as long as src and dst are on the same filesystem (which should be the case). This feature can also be optionally enabled. Signed-off-by: Milan Pandurov <milan.pandurov@tenderly.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
We can dump all the proposed blocks to the filesystem in
proposalssubdir and once they get finalised - simply move them to the correct archive directory. Benefit of this approach is that applications ingesting monad events can rely completely on the filesystem operations (including inotify) to detect new blocks, without waiting for block to be verified.This is a RFC commit, there are things that need to be cleaned up + it hasn't been tested.
I think this approach shouldn't add much overhead, unless we are expecting to have lot of blocks which are proposed but not verified. rename(2) should be pretty much an instant operation as long as src and dst are on the same filesystem (which should be the case). This feature can also be optionally enabled.