Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unit correction #461

Merged
merged 1 commit into from
Sep 10, 2024
Merged

fix: unit correction #461

merged 1 commit into from
Sep 10, 2024

Conversation

FMcil
Copy link
Contributor

@FMcil FMcil commented Sep 10, 2024

av_a2 -> av_a3

I changed av_a2 everywhere

Summary by Sourcery

Fix the unit label from 'av_a2' to 'av_a3' in the geometric properties featurizer and update corresponding tests to ensure consistency.

Bug Fixes:

  • Correct the unit label from 'av_a2' to 'av_a3' in the geometric properties featurizer.

Tests:

  • Update test expectations to reflect the corrected unit label from 'av_a2' to 'av_a3'.

Copy link

sourcery-ai bot commented Sep 10, 2024

Reviewer's Guide by Sourcery

This pull request corrects a unit label from 'av_a2' to 'av_a3' in the geometric properties featurizer and its corresponding test file. The change is straightforward and affects only two files.

File-Level Changes

Change Details Files
Corrected the unit label from 'av_a2' to 'av_a3' in the geometric properties featurizer
  • Updated the label in the list of labels for the featurizer
  • Changed 'av_a2' to 'av_a3' in the expected labels for the test case
src/mofdscribe/featurizers/pore/geometric_properties.py
tests/featurizers/pore/test_geometric_properties.py

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @FMcil - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider providing more context in the commit message about why this unit correction was necessary and what 'av_a2' and 'av_a3' represent.
  • It might be helpful to add a brief inline comment explaining what these units (av_a3) represent to prevent future confusion.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟡 Testing: 1 issue found
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@kjappelbaum
Copy link
Owner

lgtm, thanks!

@kjappelbaum kjappelbaum merged commit 0c28cdf into kjappelbaum:main Sep 10, 2024
1 of 4 checks passed
@FMcil FMcil deleted the unit-fix branch September 10, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants