Skip to content
This repository has been archived by the owner on Feb 21, 2022. It is now read-only.

Entity model #405

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Entity model #405

wants to merge 12 commits into from

Conversation

jarosevcik
Copy link
Contributor

No description provided.

@jarosevcik jarosevcik changed the title Entity model WIP: Entity model Jun 17, 2021
@lgtm-com
Copy link

lgtm-com bot commented Jun 24, 2021

This pull request introduces 8 alerts when merging 14dc725 into 2070434 - view on LGTM.com

new alerts:

  • 6 for Unused import
  • 2 for Unused local variable

@sourcery-ai sourcery-ai bot mentioned this pull request Jul 1, 2021
Closed
@lgtm-com
Copy link

lgtm-com bot commented Jul 1, 2021

This pull request introduces 10 alerts when merging 15356dc into 2070434 - view on LGTM.com

new alerts:

  • 8 for Unused import
  • 2 for Unused local variable

@lgtm-com
Copy link

lgtm-com bot commented Jul 6, 2021

This pull request introduces 7 alerts when merging 0add7ca into 2070434 - view on LGTM.com

new alerts:

  • 7 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented Jul 12, 2021

This pull request introduces 8 alerts when merging 034f65f into 2070434 - view on LGTM.com

new alerts:

  • 8 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented Jul 13, 2021

This pull request introduces 8 alerts when merging c09142e into 2070434 - view on LGTM.com

new alerts:

  • 8 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented Jul 13, 2021

This pull request introduces 8 alerts when merging 15e7d1a into 2070434 - view on LGTM.com

new alerts:

  • 8 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented Jul 13, 2021

This pull request introduces 8 alerts when merging e3c8f58 into 2070434 - view on LGTM.com

new alerts:

  • 8 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented Jul 15, 2021

This pull request introduces 8 alerts when merging 3896196 into 2070434 - view on LGTM.com

new alerts:

  • 8 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented Jul 15, 2021

This pull request introduces 9 alerts when merging 85ff458 into 2070434 - view on LGTM.com

new alerts:

  • 9 for Unused import

@jarosevcik jarosevcik force-pushed the jaro/entity_model branch 2 times, most recently from 5944e76 to b9bf8d0 Compare July 19, 2021 09:31
@lgtm-com
Copy link

lgtm-com bot commented Jul 19, 2021

This pull request introduces 8 alerts when merging b9bf8d0 into 2070434 - view on LGTM.com

new alerts:

  • 8 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented Jul 19, 2021

This pull request introduces 8 alerts when merging f8d924e into 2070434 - view on LGTM.com

new alerts:

  • 8 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented Jul 20, 2021

This pull request introduces 8 alerts when merging ee13244 into 2070434 - view on LGTM.com

new alerts:

  • 8 for Unused import

@jarosevcik jarosevcik force-pushed the jaro/entity_model branch 2 times, most recently from 3376ea9 to aab42a0 Compare July 20, 2021 12:18
aexvir
aexvir suggested changes Jul 22, 2021
View reviewed changes
zoo/services/constants.py
@@ -1,7 +1,7 @@
from enum import Enum


class Status(Enum):
class Lifecycle(Enum):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not only for services, it's for any entity, I think we should move this to zoo/entities

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall i then move the lifecycle to schema metadata?Also thinking about the initial application of this changes, we need to keep the lifecycle on service and library, then generate yaml files, import it as entity where we can store it on Entity model and then we can remove the fields from service and library... or can you think the different approach?

zoo/services/migrations/0028_auto_20210701_1130.py Outdated Show resolved Hide resolved
zoo/libraries/migrations/0004_auto_20210701_1130.py Outdated Show resolved Hide resolved
zoo/entities/models.py Show resolved Hide resolved
zoo/entities/models.py Show resolved Hide resolved
zoo/entities/yaml_definitions/component_library.yaml Outdated Show resolved Hide resolved
zoo/repos/entities_yaml.py Outdated Show resolved Hide resolved
zoo/entities/builder.py Show resolved Hide resolved
test/entities/test_yaml_to_objects.py Outdated Show resolved Hide resolved
zoo/repos/entities_yaml.py Show resolved Hide resolved
@aexvir
Copy link
Contributor

aexvir commented Jul 22, 2021

also... I'm totally up for having multiple commits to make this easier to review as there are two big chunks of work, first changing the models then updating the api, but right now those 5 commits we have don't really seem meaningful, so please squash/rename/split what's needed to have it clear

@aexvir
Copy link
Contributor

aexvir commented Jul 22, 2021

and don't forget about the README.md 😅
it's still mentioning the old schema

@jarosevcik jarosevcik force-pushed the jaro/entity_model branch 4 times, most recently from 1179161 to 981f4fb Compare July 27, 2021 09:13
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Oct 13, 2021

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 3.12%.

Quality metrics Before After Change
Complexity 2.40 ⭐ 2.37 ⭐ -0.03 👍
Method Length 50.96 ⭐ 52.19 ⭐ 1.23 👎
Working memory 8.63 🙂 9.58 🙂 0.95 👎
Quality 74.15% 🙂 71.03% 🙂 -3.12% 👎
Other metrics Before After Change
Lines 4652 3808 -844
Changed files Quality Before Quality After Quality Change
test/conftest.py 82.19% ⭐ 78.83% ⭐ -3.36% 👎
test/api/query/test_node.py 80.74% ⭐ 80.74% ⭐ 0.00%
test/api/query/test_service_environments.py 88.68% ⭐ 88.68% ⭐ 0.00%
test/api/query/test_services.py 86.36% ⭐ 87.45% ⭐ 1.09% 👍
test/api/query/snapshots/snap_test_node.py 76.49% ⭐ 76.49% ⭐ 0.00%
test/api/query/snapshots/snap_test_services.py 51.92% 🙂 52.04% 🙂 0.12% 👍
test/globalsearch/test_indexer.py 80.21% ⭐ 80.87% ⭐ 0.66% 👍
test/globalsearch/test_utils.py 85.69% ⭐ 85.69% ⭐ 0.00%
zoo/factories.py 51.89% 🙂 42.70% 😞 -9.19% 👎
zoo/api/query.py 66.22% 🙂 67.46% 🙂 1.24% 👍
zoo/api/schema.py 84.39% ⭐ 83.10% ⭐ -1.29% 👎
zoo/api/types.py 86.50% ⭐ 87.21% ⭐ 0.71% 👍
zoo/base/apps.py 65.09% 🙂 65.09% 🙂 0.00%
zoo/base/settings.py 36.83% 😞 36.83% 😞 0.00%
zoo/base/management/commands/generatezooyml.py 82.43% ⭐ 82.43% ⭐ 0.00%
zoo/base/templatetags/utils.py 86.02% ⭐ 86.02% ⭐ 0.00%
zoo/checklists/views.py 66.51% 🙂 66.51% 🙂 0.00%
zoo/libraries/models.py 93.81% ⭐ 93.48% ⭐ -0.33% 👎
zoo/libraries/urls.py 87.49% ⭐ 91.89% ⭐ 4.40% 👍
zoo/libraries/views.py 81.08% ⭐ 78.84% ⭐ -2.24% 👎
zoo/repos/tasks.py 64.90% 🙂 66.44% 🙂 1.54% 👍
zoo/repos/utils.py 50.67% 🙂 54.06% 🙂 3.39% 👍
zoo/services/constants.py 93.42% ⭐ 93.42% ⭐ 0.00%
zoo/services/models.py 77.56% ⭐ 79.82% ⭐ 2.26% 👍
zoo/services/urls.py 86.08% ⭐ 90.40% ⭐ 4.32% 👍
zoo/services/views.py 77.36% ⭐ 75.98% ⭐ -1.38% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
zoo/repos/utils.py download_repository.openapi_definition 22 😞 246 ⛔ 13 😞 31.00% 😞 Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
zoo/repos/tasks.py sync_repos.sync_entity_file.update_or_create_components.sync_enviroments_from_gitlab 7 ⭐ 161 😞 13 😞 49.70% 😞 Try splitting into smaller methods. Extract out complex expressions
zoo/api/query.py Query.resolve_all_search_results 4 ⭐ 149 😞 13 😞 53.85% 🙂 Try splitting into smaller methods. Extract out complex expressions
zoo/repos/tasks.py sync_repos 14 🙂 151 😞 8 🙂 53.85% 🙂 Try splitting into smaller methods
zoo/services/models.py Service.rate_according_to_sentry 1 ⭐ 125 😞 16 ⛔ 55.77% 🙂 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Oct 13, 2021

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 3.12%.

Quality metrics Before After Change
Complexity 2.40 ⭐ 2.37 ⭐ -0.03 👍
Method Length 50.96 ⭐ 52.19 ⭐ 1.23 👎
Working memory 8.63 🙂 9.58 🙂 0.95 👎
Quality 74.15% 🙂 71.03% 🙂 -3.12% 👎
Other metrics Before After Change
Lines 4652 3806 -846
Changed files Quality Before Quality After Quality Change
test/conftest.py 82.19% ⭐ 78.83% ⭐ -3.36% 👎
test/api/query/test_node.py 80.74% ⭐ 80.74% ⭐ 0.00%
test/api/query/test_service_environments.py 88.68% ⭐ 88.68% ⭐ 0.00%
test/api/query/test_services.py 86.36% ⭐ 87.45% ⭐ 1.09% 👍
test/api/query/snapshots/snap_test_node.py 76.49% ⭐ 76.49% ⭐ 0.00%
test/api/query/snapshots/snap_test_services.py 51.92% 🙂 52.04% 🙂 0.12% 👍
test/globalsearch/test_indexer.py 80.21% ⭐ 80.87% ⭐ 0.66% 👍
test/globalsearch/test_utils.py 85.69% ⭐ 85.69% ⭐ 0.00%
zoo/factories.py 51.89% 🙂 42.70% 😞 -9.19% 👎
zoo/api/query.py 66.22% 🙂 67.46% 🙂 1.24% 👍
zoo/api/schema.py 84.39% ⭐ 83.10% ⭐ -1.29% 👎
zoo/api/types.py 86.50% ⭐ 87.21% ⭐ 0.71% 👍
zoo/base/apps.py 65.09% 🙂 65.09% 🙂 0.00%
zoo/base/settings.py 36.83% 😞 36.83% 😞 0.00%
zoo/base/management/commands/generatezooyml.py 82.43% ⭐ 82.43% ⭐ 0.00%
zoo/base/templatetags/utils.py 86.02% ⭐ 86.02% ⭐ 0.00%
zoo/checklists/views.py 66.51% 🙂 66.51% 🙂 0.00%
zoo/libraries/models.py 93.81% ⭐ 93.48% ⭐ -0.33% 👎
zoo/libraries/urls.py 87.49% ⭐ 91.89% ⭐ 4.40% 👍
zoo/libraries/views.py 81.08% ⭐ 78.84% ⭐ -2.24% 👎
zoo/repos/tasks.py 64.90% 🙂 66.44% 🙂 1.54% 👍
zoo/repos/utils.py 50.67% 🙂 54.06% 🙂 3.39% 👍
zoo/services/constants.py 93.42% ⭐ 93.42% ⭐ 0.00%
zoo/services/models.py 77.56% ⭐ 79.82% ⭐ 2.26% 👍
zoo/services/urls.py 86.08% ⭐ 90.40% ⭐ 4.32% 👍
zoo/services/views.py 77.36% ⭐ 75.98% ⭐ -1.38% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
zoo/repos/utils.py download_repository.openapi_definition 22 😞 246 ⛔ 13 😞 31.00% 😞 Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
zoo/repos/tasks.py sync_repos.sync_entity_file.update_or_create_components.sync_enviroments_from_gitlab 7 ⭐ 161 😞 13 😞 49.70% 😞 Try splitting into smaller methods. Extract out complex expressions
zoo/api/query.py Query.resolve_all_search_results 4 ⭐ 149 😞 13 😞 53.85% 🙂 Try splitting into smaller methods. Extract out complex expressions
zoo/repos/tasks.py sync_repos 14 🙂 151 😞 8 🙂 53.85% 🙂 Try splitting into smaller methods
zoo/services/models.py Service.rate_according_to_sentry 1 ⭐ 125 😞 16 ⛔ 55.77% 🙂 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@lgtm-com
Copy link

lgtm-com bot commented Oct 13, 2021

This pull request fixes 1 alert when merging bcb68e4 into fee0108 - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Oct 15, 2021

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 3.12%.

Quality metrics Before After Change
Complexity 2.40 ⭐ 2.37 ⭐ -0.03 👍
Method Length 50.96 ⭐ 52.19 ⭐ 1.23 👎
Working memory 8.63 🙂 9.58 🙂 0.95 👎
Quality 74.15% 🙂 71.03% 🙂 -3.12% 👎
Other metrics Before After Change
Lines 4652 3806 -846
Changed files Quality Before Quality After Quality Change
test/conftest.py 82.19% ⭐ 78.83% ⭐ -3.36% 👎
test/api/query/test_node.py 80.74% ⭐ 80.74% ⭐ 0.00%
test/api/query/test_service_environments.py 88.68% ⭐ 88.68% ⭐ 0.00%
test/api/query/test_services.py 86.36% ⭐ 87.45% ⭐ 1.09% 👍
test/api/query/snapshots/snap_test_node.py 76.49% ⭐ 76.49% ⭐ 0.00%
test/api/query/snapshots/snap_test_services.py 51.92% 🙂 52.04% 🙂 0.12% 👍
test/globalsearch/test_indexer.py 80.21% ⭐ 80.87% ⭐ 0.66% 👍
test/globalsearch/test_utils.py 85.69% ⭐ 85.69% ⭐ 0.00%
zoo/factories.py 51.89% 🙂 42.70% 😞 -9.19% 👎
zoo/api/query.py 66.22% 🙂 67.46% 🙂 1.24% 👍
zoo/api/schema.py 84.39% ⭐ 83.10% ⭐ -1.29% 👎
zoo/api/types.py 86.50% ⭐ 87.21% ⭐ 0.71% 👍
zoo/base/apps.py 65.09% 🙂 65.09% 🙂 0.00%
zoo/base/settings.py 36.83% 😞 36.83% 😞 0.00%
zoo/base/management/commands/generatezooyml.py 82.43% ⭐ 82.43% ⭐ 0.00%
zoo/base/templatetags/utils.py 86.02% ⭐ 86.02% ⭐ 0.00%
zoo/checklists/views.py 66.51% 🙂 66.51% 🙂 0.00%
zoo/libraries/models.py 93.81% ⭐ 93.48% ⭐ -0.33% 👎
zoo/libraries/urls.py 87.49% ⭐ 91.89% ⭐ 4.40% 👍
zoo/libraries/views.py 81.08% ⭐ 78.84% ⭐ -2.24% 👎
zoo/repos/tasks.py 64.90% 🙂 66.44% 🙂 1.54% 👍
zoo/repos/utils.py 50.67% 🙂 54.06% 🙂 3.39% 👍
zoo/services/constants.py 93.42% ⭐ 93.42% ⭐ 0.00%
zoo/services/models.py 77.56% ⭐ 79.82% ⭐ 2.26% 👍
zoo/services/urls.py 86.08% ⭐ 90.40% ⭐ 4.32% 👍
zoo/services/views.py 77.36% ⭐ 75.98% ⭐ -1.38% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
zoo/repos/utils.py download_repository.openapi_definition 22 😞 246 ⛔ 13 😞 31.00% 😞 Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
zoo/repos/tasks.py sync_repos.sync_entity_file.update_or_create_components.sync_enviroments_from_gitlab 7 ⭐ 161 😞 13 😞 49.70% 😞 Try splitting into smaller methods. Extract out complex expressions
zoo/api/query.py Query.resolve_all_search_results 4 ⭐ 149 😞 13 😞 53.85% 🙂 Try splitting into smaller methods. Extract out complex expressions
zoo/repos/tasks.py sync_repos 14 🙂 151 😞 8 🙂 53.85% 🙂 Try splitting into smaller methods
zoo/services/models.py Service.rate_according_to_sentry 1 ⭐ 125 😞 16 ⛔ 55.77% 🙂 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@lgtm-com
Copy link

lgtm-com bot commented Oct 15, 2021

This pull request fixes 1 alert when merging 84ab43d into fee0108 - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Oct 20, 2021

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 3.12%.

Quality metrics Before After Change
Complexity 2.40 ⭐ 2.37 ⭐ -0.03 👍
Method Length 50.96 ⭐ 52.19 ⭐ 1.23 👎
Working memory 8.63 🙂 9.58 🙂 0.95 👎
Quality 74.15% 🙂 71.03% 🙂 -3.12% 👎
Other metrics Before After Change
Lines 4652 3806 -846
Changed files Quality Before Quality After Quality Change
test/conftest.py 82.19% ⭐ 78.83% ⭐ -3.36% 👎
test/api/query/test_node.py 80.74% ⭐ 80.74% ⭐ 0.00%
test/api/query/test_service_environments.py 88.68% ⭐ 88.68% ⭐ 0.00%
test/api/query/test_services.py 86.36% ⭐ 87.45% ⭐ 1.09% 👍
test/api/query/snapshots/snap_test_node.py 76.49% ⭐ 76.49% ⭐ 0.00%
test/api/query/snapshots/snap_test_services.py 51.92% 🙂 52.04% 🙂 0.12% 👍
test/globalsearch/test_indexer.py 80.21% ⭐ 80.87% ⭐ 0.66% 👍
test/globalsearch/test_utils.py 85.69% ⭐ 85.69% ⭐ 0.00%
zoo/factories.py 51.89% 🙂 42.70% 😞 -9.19% 👎
zoo/api/query.py 66.22% 🙂 67.46% 🙂 1.24% 👍
zoo/api/schema.py 84.39% ⭐ 83.10% ⭐ -1.29% 👎
zoo/api/types.py 86.50% ⭐ 87.21% ⭐ 0.71% 👍
zoo/base/apps.py 65.09% 🙂 65.09% 🙂 0.00%
zoo/base/settings.py 36.83% 😞 36.83% 😞 0.00%
zoo/base/management/commands/generatezooyml.py 82.43% ⭐ 82.43% ⭐ 0.00%
zoo/base/templatetags/utils.py 86.02% ⭐ 86.02% ⭐ 0.00%
zoo/checklists/views.py 66.51% 🙂 66.51% 🙂 0.00%
zoo/libraries/models.py 93.81% ⭐ 93.48% ⭐ -0.33% 👎
zoo/libraries/urls.py 87.49% ⭐ 91.89% ⭐ 4.40% 👍
zoo/libraries/views.py 81.08% ⭐ 78.84% ⭐ -2.24% 👎
zoo/repos/tasks.py 64.90% 🙂 66.44% 🙂 1.54% 👍
zoo/repos/utils.py 50.67% 🙂 54.06% 🙂 3.39% 👍
zoo/services/constants.py 93.42% ⭐ 93.42% ⭐ 0.00%
zoo/services/models.py 77.56% ⭐ 79.82% ⭐ 2.26% 👍
zoo/services/urls.py 86.08% ⭐ 90.40% ⭐ 4.32% 👍
zoo/services/views.py 77.36% ⭐ 75.98% ⭐ -1.38% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
zoo/repos/utils.py download_repository.openapi_definition 22 😞 246 ⛔ 13 😞 31.00% 😞 Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
zoo/repos/tasks.py sync_repos.sync_entity_file.update_or_create_components.sync_enviroments_from_gitlab 7 ⭐ 161 😞 13 😞 49.70% 😞 Try splitting into smaller methods. Extract out complex expressions
zoo/api/query.py Query.resolve_all_search_results 4 ⭐ 149 😞 13 😞 53.85% 🙂 Try splitting into smaller methods. Extract out complex expressions
zoo/repos/tasks.py sync_repos 14 🙂 151 😞 8 🙂 53.85% 🙂 Try splitting into smaller methods
zoo/services/models.py Service.rate_according_to_sentry 1 ⭐ 125 😞 16 ⛔ 55.77% 🙂 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@lgtm-com
Copy link

lgtm-com bot commented Oct 20, 2021

This pull request fixes 1 alert when merging e61a0ab into fee0108 - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Oct 20, 2021

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 3.12%.

Quality metrics Before After Change
Complexity 2.40 ⭐ 2.37 ⭐ -0.03 👍
Method Length 50.96 ⭐ 52.19 ⭐ 1.23 👎
Working memory 8.63 🙂 9.58 🙂 0.95 👎
Quality 74.15% 🙂 71.03% 🙂 -3.12% 👎
Other metrics Before After Change
Lines 4652 3806 -846
Changed files Quality Before Quality After Quality Change
test/conftest.py 82.19% ⭐ 78.83% ⭐ -3.36% 👎
test/api/query/test_node.py 80.74% ⭐ 80.74% ⭐ 0.00%
test/api/query/test_service_environments.py 88.68% ⭐ 88.68% ⭐ 0.00%
test/api/query/test_services.py 86.36% ⭐ 87.45% ⭐ 1.09% 👍
test/api/query/snapshots/snap_test_node.py 76.49% ⭐ 76.49% ⭐ 0.00%
test/api/query/snapshots/snap_test_services.py 51.92% 🙂 52.04% 🙂 0.12% 👍
test/globalsearch/test_indexer.py 80.21% ⭐ 80.87% ⭐ 0.66% 👍
test/globalsearch/test_utils.py 85.69% ⭐ 85.69% ⭐ 0.00%
zoo/factories.py 51.89% 🙂 42.70% 😞 -9.19% 👎
zoo/api/query.py 66.22% 🙂 67.46% 🙂 1.24% 👍
zoo/api/schema.py 84.39% ⭐ 83.10% ⭐ -1.29% 👎
zoo/api/types.py 86.50% ⭐ 87.21% ⭐ 0.71% 👍
zoo/base/apps.py 65.09% 🙂 65.09% 🙂 0.00%
zoo/base/settings.py 36.83% 😞 36.83% 😞 0.00%
zoo/base/management/commands/generatezooyml.py 82.43% ⭐ 82.43% ⭐ 0.00%
zoo/base/templatetags/utils.py 86.02% ⭐ 86.02% ⭐ 0.00%
zoo/checklists/views.py 66.51% 🙂 66.51% 🙂 0.00%
zoo/libraries/models.py 93.81% ⭐ 93.48% ⭐ -0.33% 👎
zoo/libraries/urls.py 87.49% ⭐ 91.89% ⭐ 4.40% 👍
zoo/libraries/views.py 81.08% ⭐ 78.84% ⭐ -2.24% 👎
zoo/repos/tasks.py 64.90% 🙂 66.44% 🙂 1.54% 👍
zoo/repos/utils.py 50.67% 🙂 54.06% 🙂 3.39% 👍
zoo/services/constants.py 93.42% ⭐ 93.42% ⭐ 0.00%
zoo/services/models.py 77.56% ⭐ 79.82% ⭐ 2.26% 👍
zoo/services/urls.py 86.08% ⭐ 90.40% ⭐ 4.32% 👍
zoo/services/views.py 77.36% ⭐ 75.98% ⭐ -1.38% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
zoo/repos/utils.py download_repository.openapi_definition 22 😞 246 ⛔ 13 😞 31.00% 😞 Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
zoo/repos/tasks.py sync_repos.sync_entity_file.update_or_create_components.sync_enviroments_from_gitlab 7 ⭐ 161 😞 13 😞 49.70% 😞 Try splitting into smaller methods. Extract out complex expressions
zoo/api/query.py Query.resolve_all_search_results 4 ⭐ 149 😞 13 😞 53.85% 🙂 Try splitting into smaller methods. Extract out complex expressions
zoo/repos/tasks.py sync_repos 14 🙂 151 😞 8 🙂 53.85% 🙂 Try splitting into smaller methods
zoo/services/models.py Service.rate_according_to_sentry 1 ⭐ 125 😞 16 ⛔ 55.77% 🙂 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@lgtm-com
Copy link

lgtm-com bot commented Oct 20, 2021

This pull request fixes 1 alert when merging 791126c into fee0108 - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Oct 20, 2021

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 3.12%.

Quality metrics Before After Change
Complexity 2.40 ⭐ 2.37 ⭐ -0.03 👍
Method Length 50.96 ⭐ 52.19 ⭐ 1.23 👎
Working memory 8.63 🙂 9.58 🙂 0.95 👎
Quality 74.15% 🙂 71.03% 🙂 -3.12% 👎
Other metrics Before After Change
Lines 4652 3806 -846
Changed files Quality Before Quality After Quality Change
test/conftest.py 82.19% ⭐ 78.83% ⭐ -3.36% 👎
test/api/query/test_node.py 80.74% ⭐ 80.74% ⭐ 0.00%
test/api/query/test_service_environments.py 88.68% ⭐ 88.68% ⭐ 0.00%
test/api/query/test_services.py 86.36% ⭐ 87.45% ⭐ 1.09% 👍
test/api/query/snapshots/snap_test_node.py 76.49% ⭐ 76.49% ⭐ 0.00%
test/api/query/snapshots/snap_test_services.py 51.92% 🙂 52.04% 🙂 0.12% 👍
test/globalsearch/test_indexer.py 80.21% ⭐ 80.87% ⭐ 0.66% 👍
test/globalsearch/test_utils.py 85.69% ⭐ 85.69% ⭐ 0.00%
zoo/factories.py 51.89% 🙂 42.70% 😞 -9.19% 👎
zoo/api/query.py 66.22% 🙂 67.46% 🙂 1.24% 👍
zoo/api/schema.py 84.39% ⭐ 83.10% ⭐ -1.29% 👎
zoo/api/types.py 86.50% ⭐ 87.21% ⭐ 0.71% 👍
zoo/base/apps.py 65.09% 🙂 65.09% 🙂 0.00%
zoo/base/settings.py 36.83% 😞 36.83% 😞 0.00%
zoo/base/management/commands/generatezooyml.py 82.43% ⭐ 82.43% ⭐ 0.00%
zoo/base/templatetags/utils.py 86.02% ⭐ 86.02% ⭐ 0.00%
zoo/checklists/views.py 66.51% 🙂 66.51% 🙂 0.00%
zoo/libraries/models.py 93.81% ⭐ 93.48% ⭐ -0.33% 👎
zoo/libraries/urls.py 87.49% ⭐ 91.89% ⭐ 4.40% 👍
zoo/libraries/views.py 81.08% ⭐ 78.84% ⭐ -2.24% 👎
zoo/repos/tasks.py 64.90% 🙂 66.44% 🙂 1.54% 👍
zoo/repos/utils.py 50.67% 🙂 54.06% 🙂 3.39% 👍
zoo/services/constants.py 93.42% ⭐ 93.42% ⭐ 0.00%
zoo/services/models.py 77.56% ⭐ 79.82% ⭐ 2.26% 👍
zoo/services/urls.py 86.08% ⭐ 90.40% ⭐ 4.32% 👍
zoo/services/views.py 77.36% ⭐ 75.98% ⭐ -1.38% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
zoo/repos/utils.py download_repository.openapi_definition 22 😞 246 ⛔ 13 😞 31.00% 😞 Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
zoo/repos/tasks.py sync_repos.sync_entity_file.update_or_create_components.sync_enviroments_from_gitlab 7 ⭐ 161 😞 13 😞 49.70% 😞 Try splitting into smaller methods. Extract out complex expressions
zoo/api/query.py Query.resolve_all_search_results 4 ⭐ 149 😞 13 😞 53.85% 🙂 Try splitting into smaller methods. Extract out complex expressions
zoo/repos/tasks.py sync_repos 14 🙂 151 😞 8 🙂 53.85% 🙂 Try splitting into smaller methods
zoo/services/models.py Service.rate_according_to_sentry 1 ⭐ 125 😞 16 ⛔ 55.77% 🙂 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@lgtm-com
Copy link

lgtm-com bot commented Oct 20, 2021

This pull request fixes 1 alert when merging eff8221 into fee0108 - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@sonarcloud
Copy link

sonarcloud bot commented Oct 20, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 3 Security Hotspots
Code Smell A 2 Code Smells

73.0% 73.0% Coverage
0.0% 0.0% Duplication

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Oct 26, 2021

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 3.12%.

Quality metrics Before After Change
Complexity 2.40 ⭐ 2.37 ⭐ -0.03 👍
Method Length 50.96 ⭐ 52.25 ⭐ 1.29 👎
Working memory 8.63 🙂 9.57 🙂 0.94 👎
Quality 74.15% 🙂 71.03% 🙂 -3.12% 👎
Other metrics Before After Change
Lines 4652 3809 -843
Changed files Quality Before Quality After Quality Change
test/conftest.py 82.19% ⭐ 78.83% ⭐ -3.36% 👎
test/api/query/test_node.py 80.74% ⭐ 80.74% ⭐ 0.00%
test/api/query/test_service_environments.py 88.68% ⭐ 88.68% ⭐ 0.00%
test/api/query/test_services.py 86.36% ⭐ 87.45% ⭐ 1.09% 👍
test/api/query/snapshots/snap_test_node.py 76.49% ⭐ 76.49% ⭐ 0.00%
test/api/query/snapshots/snap_test_services.py 51.92% 🙂 52.04% 🙂 0.12% 👍
test/globalsearch/test_indexer.py 80.21% ⭐ 80.87% ⭐ 0.66% 👍
test/globalsearch/test_utils.py 85.69% ⭐ 85.69% ⭐ 0.00%
zoo/factories.py 51.89% 🙂 42.70% 😞 -9.19% 👎
zoo/api/query.py 66.22% 🙂 67.46% 🙂 1.24% 👍
zoo/api/schema.py 84.39% ⭐ 83.10% ⭐ -1.29% 👎
zoo/api/types.py 86.50% ⭐ 87.21% ⭐ 0.71% 👍
zoo/base/apps.py 65.09% 🙂 65.09% 🙂 0.00%
zoo/base/settings.py 36.83% 😞 36.83% 😞 0.00%
zoo/base/management/commands/generatezooyml.py 82.43% ⭐ 82.43% ⭐ 0.00%
zoo/base/templatetags/utils.py 86.02% ⭐ 86.02% ⭐ 0.00%
zoo/checklists/views.py 66.51% 🙂 66.51% 🙂 0.00%
zoo/libraries/models.py 93.81% ⭐ 93.48% ⭐ -0.33% 👎
zoo/libraries/urls.py 87.49% ⭐ 91.89% ⭐ 4.40% 👍
zoo/libraries/views.py 81.08% ⭐ 78.84% ⭐ -2.24% 👎
zoo/repos/tasks.py 64.90% 🙂 66.55% 🙂 1.65% 👍
zoo/repos/utils.py 50.67% 🙂 54.06% 🙂 3.39% 👍
zoo/services/constants.py 93.42% ⭐ 93.42% ⭐ 0.00%
zoo/services/models.py 77.56% ⭐ 79.82% ⭐ 2.26% 👍
zoo/services/urls.py 86.08% ⭐ 90.40% ⭐ 4.32% 👍
zoo/services/views.py 77.36% ⭐ 75.98% ⭐ -1.38% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
zoo/repos/utils.py download_repository.openapi_definition 22 😞 246 ⛔ 13 😞 31.00% 😞 Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
zoo/repos/tasks.py sync_repos.sync_entity_file.update_or_create_components.sync_enviroments_from_gitlab 7 ⭐ 161 😞 13 😞 49.70% 😞 Try splitting into smaller methods. Extract out complex expressions
zoo/api/query.py Query.resolve_all_search_results 4 ⭐ 149 😞 13 😞 53.85% 🙂 Try splitting into smaller methods. Extract out complex expressions
zoo/repos/tasks.py sync_repos 14 🙂 151 😞 8 🙂 53.85% 🙂 Try splitting into smaller methods
zoo/services/models.py Service.rate_according_to_sentry 1 ⭐ 125 😞 16 ⛔ 55.77% 🙂 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Oct 27, 2021

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 3.12%.

Quality metrics Before After Change
Complexity 2.40 ⭐ 2.37 ⭐ -0.03 👍
Method Length 50.96 ⭐ 52.25 ⭐ 1.29 👎
Working memory 8.63 🙂 9.57 🙂 0.94 👎
Quality 74.15% 🙂 71.03% 🙂 -3.12% 👎
Other metrics Before After Change
Lines 4652 3809 -843
Changed files Quality Before Quality After Quality Change
test/conftest.py 82.19% ⭐ 78.83% ⭐ -3.36% 👎
test/api/query/test_node.py 80.74% ⭐ 80.74% ⭐ 0.00%
test/api/query/test_service_environments.py 88.68% ⭐ 88.68% ⭐ 0.00%
test/api/query/test_services.py 86.36% ⭐ 87.45% ⭐ 1.09% 👍
test/api/query/snapshots/snap_test_node.py 76.49% ⭐ 76.49% ⭐ 0.00%
test/api/query/snapshots/snap_test_services.py 51.92% 🙂 52.04% 🙂 0.12% 👍
test/globalsearch/test_indexer.py 80.21% ⭐ 80.87% ⭐ 0.66% 👍
test/globalsearch/test_utils.py 85.69% ⭐ 85.69% ⭐ 0.00%
zoo/factories.py 51.89% 🙂 42.70% 😞 -9.19% 👎
zoo/api/query.py 66.22% 🙂 67.46% 🙂 1.24% 👍
zoo/api/schema.py 84.39% ⭐ 83.10% ⭐ -1.29% 👎
zoo/api/types.py 86.50% ⭐ 87.21% ⭐ 0.71% 👍
zoo/base/apps.py 65.09% 🙂 65.09% 🙂 0.00%
zoo/base/settings.py 36.83% 😞 36.83% 😞 0.00%
zoo/base/management/commands/generatezooyml.py 82.43% ⭐ 82.43% ⭐ 0.00%
zoo/base/templatetags/utils.py 86.02% ⭐ 86.02% ⭐ 0.00%
zoo/checklists/views.py 66.51% 🙂 66.51% 🙂 0.00%
zoo/libraries/models.py 93.81% ⭐ 93.48% ⭐ -0.33% 👎
zoo/libraries/urls.py 87.49% ⭐ 91.89% ⭐ 4.40% 👍
zoo/libraries/views.py 81.08% ⭐ 78.84% ⭐ -2.24% 👎
zoo/repos/tasks.py 64.90% 🙂 66.55% 🙂 1.65% 👍
zoo/repos/utils.py 50.67% 🙂 54.06% 🙂 3.39% 👍
zoo/services/constants.py 93.42% ⭐ 93.42% ⭐ 0.00%
zoo/services/models.py 77.56% ⭐ 79.82% ⭐ 2.26% 👍
zoo/services/urls.py 86.08% ⭐ 90.40% ⭐ 4.32% 👍
zoo/services/views.py 77.36% ⭐ 75.98% ⭐ -1.38% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
zoo/repos/utils.py download_repository.openapi_definition 22 😞 246 ⛔ 13 😞 31.00% 😞 Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
zoo/repos/tasks.py sync_repos.sync_entity_file.update_or_create_components.sync_enviroments_from_gitlab 7 ⭐ 161 😞 13 😞 49.70% 😞 Try splitting into smaller methods. Extract out complex expressions
zoo/api/query.py Query.resolve_all_search_results 4 ⭐ 149 😞 13 😞 53.85% 🙂 Try splitting into smaller methods. Extract out complex expressions
zoo/repos/tasks.py sync_repos 14 🙂 151 😞 8 🙂 53.85% 🙂 Try splitting into smaller methods
zoo/services/models.py Service.rate_according_to_sentry 1 ⭐ 125 😞 16 ⛔ 55.77% 🙂 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@lgtm-com
Copy link

lgtm-com bot commented Oct 27, 2021

This pull request fixes 1 alert when merging 54c7197 into fee0108 - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Oct 27, 2021

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 3.12%.

Quality metrics Before After Change
Complexity 2.40 ⭐ 2.37 ⭐ -0.03 👍
Method Length 50.96 ⭐ 52.25 ⭐ 1.29 👎
Working memory 8.63 🙂 9.57 🙂 0.94 👎
Quality 74.15% 🙂 71.03% 🙂 -3.12% 👎
Other metrics Before After Change
Lines 4652 3809 -843
Changed files Quality Before Quality After Quality Change
test/conftest.py 82.19% ⭐ 78.83% ⭐ -3.36% 👎
test/api/query/test_node.py 80.74% ⭐ 80.74% ⭐ 0.00%
test/api/query/test_service_environments.py 88.68% ⭐ 88.68% ⭐ 0.00%
test/api/query/test_services.py 86.36% ⭐ 87.45% ⭐ 1.09% 👍
test/api/query/snapshots/snap_test_node.py 76.49% ⭐ 76.49% ⭐ 0.00%
test/api/query/snapshots/snap_test_services.py 51.92% 🙂 52.04% 🙂 0.12% 👍
test/globalsearch/test_indexer.py 80.21% ⭐ 80.87% ⭐ 0.66% 👍
test/globalsearch/test_utils.py 85.69% ⭐ 85.69% ⭐ 0.00%
zoo/factories.py 51.89% 🙂 42.70% 😞 -9.19% 👎
zoo/api/query.py 66.22% 🙂 67.46% 🙂 1.24% 👍
zoo/api/schema.py 84.39% ⭐ 83.10% ⭐ -1.29% 👎
zoo/api/types.py 86.50% ⭐ 87.21% ⭐ 0.71% 👍
zoo/base/apps.py 65.09% 🙂 65.09% 🙂 0.00%
zoo/base/settings.py 36.83% 😞 36.83% 😞 0.00%
zoo/base/management/commands/generatezooyml.py 82.43% ⭐ 82.43% ⭐ 0.00%
zoo/base/templatetags/utils.py 86.02% ⭐ 86.02% ⭐ 0.00%
zoo/checklists/views.py 66.51% 🙂 66.51% 🙂 0.00%
zoo/libraries/models.py 93.81% ⭐ 93.48% ⭐ -0.33% 👎
zoo/libraries/urls.py 87.49% ⭐ 91.89% ⭐ 4.40% 👍
zoo/libraries/views.py 81.08% ⭐ 78.84% ⭐ -2.24% 👎
zoo/repos/tasks.py 64.90% 🙂 66.55% 🙂 1.65% 👍
zoo/repos/utils.py 50.67% 🙂 54.06% 🙂 3.39% 👍
zoo/services/constants.py 93.42% ⭐ 93.42% ⭐ 0.00%
zoo/services/models.py 77.56% ⭐ 79.82% ⭐ 2.26% 👍
zoo/services/urls.py 86.08% ⭐ 90.40% ⭐ 4.32% 👍
zoo/services/views.py 77.36% ⭐ 75.98% ⭐ -1.38% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
zoo/repos/utils.py download_repository.openapi_definition 22 😞 246 ⛔ 13 😞 31.00% 😞 Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
zoo/repos/tasks.py sync_repos.sync_entity_file.update_or_create_components.sync_enviroments_from_gitlab 7 ⭐ 161 😞 13 😞 49.70% 😞 Try splitting into smaller methods. Extract out complex expressions
zoo/api/query.py Query.resolve_all_search_results 4 ⭐ 149 😞 13 😞 53.85% 🙂 Try splitting into smaller methods. Extract out complex expressions
zoo/repos/tasks.py sync_repos 14 🙂 151 😞 8 🙂 53.85% 🙂 Try splitting into smaller methods
zoo/services/models.py Service.rate_according_to_sentry 1 ⭐ 125 😞 16 ⛔ 55.77% 🙂 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@lgtm-com
Copy link

lgtm-com bot commented Oct 27, 2021

This pull request fixes 1 alert when merging 3fb5995 into fee0108 - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Oct 29, 2021

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 3.12%.

Quality metrics Before After Change
Complexity 2.40 ⭐ 2.37 ⭐ -0.03 👍
Method Length 50.96 ⭐ 52.26 ⭐ 1.30 👎
Working memory 8.63 🙂 9.58 🙂 0.95 👎
Quality 74.15% 🙂 71.03% 🙂 -3.12% 👎
Other metrics Before After Change
Lines 4652 3810 -842
Changed files Quality Before Quality After Quality Change
test/conftest.py 82.19% ⭐ 78.83% ⭐ -3.36% 👎
test/api/query/test_node.py 80.74% ⭐ 80.74% ⭐ 0.00%
test/api/query/test_service_environments.py 88.68% ⭐ 88.68% ⭐ 0.00%
test/api/query/test_services.py 86.36% ⭐ 87.45% ⭐ 1.09% 👍
test/api/query/snapshots/snap_test_node.py 76.49% ⭐ 76.49% ⭐ 0.00%
test/api/query/snapshots/snap_test_services.py 51.92% 🙂 52.04% 🙂 0.12% 👍
test/globalsearch/test_indexer.py 80.21% ⭐ 80.87% ⭐ 0.66% 👍
test/globalsearch/test_utils.py 85.69% ⭐ 85.69% ⭐ 0.00%
zoo/factories.py 51.89% 🙂 42.70% 😞 -9.19% 👎
zoo/api/query.py 66.22% 🙂 67.46% 🙂 1.24% 👍
zoo/api/schema.py 84.39% ⭐ 83.10% ⭐ -1.29% 👎
zoo/api/types.py 86.50% ⭐ 87.19% ⭐ 0.69% 👍
zoo/base/apps.py 65.09% 🙂 65.09% 🙂 0.00%
zoo/base/settings.py 36.83% 😞 36.83% 😞 0.00%
zoo/base/management/commands/generatezooyml.py 82.43% ⭐ 82.43% ⭐ 0.00%
zoo/base/templatetags/utils.py 86.02% ⭐ 86.02% ⭐ 0.00%
zoo/checklists/views.py 66.51% 🙂 66.51% 🙂 0.00%
zoo/libraries/models.py 93.81% ⭐ 93.48% ⭐ -0.33% 👎
zoo/libraries/urls.py 87.49% ⭐ 91.89% ⭐ 4.40% 👍
zoo/libraries/views.py 81.08% ⭐ 78.84% ⭐ -2.24% 👎
zoo/repos/tasks.py 64.90% 🙂 66.55% 🙂 1.65% 👍
zoo/repos/utils.py 50.67% 🙂 54.06% 🙂 3.39% 👍
zoo/services/constants.py 93.42% ⭐ 93.42% ⭐ 0.00%
zoo/services/models.py 77.56% ⭐ 79.82% ⭐ 2.26% 👍
zoo/services/urls.py 86.08% ⭐ 90.40% ⭐ 4.32% 👍
zoo/services/views.py 77.36% ⭐ 75.98% ⭐ -1.38% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
zoo/repos/utils.py download_repository.openapi_definition 22 😞 246 ⛔ 13 😞 31.00% 😞 Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
zoo/repos/tasks.py sync_repos.sync_entity_file.update_or_create_components.sync_enviroments_from_gitlab 7 ⭐ 161 😞 13 😞 49.70% 😞 Try splitting into smaller methods. Extract out complex expressions
zoo/api/query.py Query.resolve_all_search_results 4 ⭐ 149 😞 13 😞 53.85% 🙂 Try splitting into smaller methods. Extract out complex expressions
zoo/repos/tasks.py sync_repos 14 🙂 151 😞 8 🙂 53.85% 🙂 Try splitting into smaller methods
zoo/services/models.py Service.rate_according_to_sentry 1 ⭐ 125 😞 16 ⛔ 55.77% 🙂 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@lgtm-com
Copy link

lgtm-com bot commented Oct 29, 2021

This pull request fixes 1 alert when merging 4886e07 into fee0108 - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@imunitic imunitic imunitic left review comments

@aexvir aexvir Awaiting requested review from aexvir

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jarosevcik @aexvir @imunitic @maroshmka