Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reinstate cppy recipe and update 3 related recipes. #3124

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

RobertFlatt
Copy link
Contributor

These 4 recipes all relate to cppy.
All 4 Python packages are from the same repository https://github.com/nucleic

  1. Reinstate cppy recipe, use PyProjectRecipe and latest version.

  2. Update atom version to latest, and add hostpython_prerequisites

  3. Update enaml version to latest, and remove patch no longer required

  4. Update kiwisolver version to latest, change depends to hostpython_prerequisites,
    and change = to += to fix kiwisolver error ld: error: undefined symbol: main #3122

(Caveat: I have absolutely no clue as to how one would test enaml on Android.)

Recreate recipe, implement as PyProjectRecipe, update version.
Update version, add cppy dependency.
Update version, remove patch.
Bump version,  change depends to hostpython_prerequisites.
Fix kivy#3122
@RobertFlatt
Copy link
Contributor Author

  1. This did not fix kiwisolver error ld: error: undefined symbol: main #3122

  2. There is also an issue on 32 bit targets having LONG_BIT defined as something other than 8 * SIZEOF_LONG.

@AndreMiras
Copy link
Member

LGTM! Thanks for picking this up and for sharing all the context.
Even though not all recipes build across all arch and OS, this is still an improvement over what we had.

Would you mind documenting the known issues in the module or class docstrings of the failing recipes?
For example, in the kiwisolver module or class docstring, note that it doesn't build on macOS and link to the related issue. Similarly, for the atom recipe, you could document the error just as you did in your comment above.

Bonus points if you squash the commits into one and include the PR description in the commit message, this would ensure that valuable context is preserved in the commit history.

@T-Dynamos
Copy link
Contributor

There is also an issue on 32 bit targets having LONG_BIT defined as something other than 8 * SIZEOF_LONG.

indicating it only supports 64bit architecture.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kiwisolver error ld: error: undefined symbol: main
3 participants