-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First implementation #1
base: main
Are you sure you want to change the base?
Conversation
I really don't like including the full volto repository clone in the image. |
The new images are a lot bigger than the existing ones. We need to do better.
|
@sneridagh I did some work on optimizing the production image in this branch: https://github.com/kitconcept/plone-frontend/compare/newapproach...newapproach-davisagli?expand=1 There is more that can be done, by avoiding a full clone of the volto repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @davisagli suggestions. About cookieplone, on Monday I will implement a hidden variable to not generate the volto addon
Optimize production image size
@davisagli I merged your branch into here. I will improve the git command for the checkout. |
@davisagli the prod image is down to 1GB, while the current one is 1.68GB:
BTW, where did you get the numbers in your previous comment? Look at the current image ones... |
Here's my attempt to update the official plone-frontend image to make both the old and new approaches available: plone/plone-frontend#47 |
No description provided.