Fix cross-compilation and MSVC build with OpenSSL #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building for multiple platforms I encountered several issues. Fist of all MSVC (Windows) build with TLS support through OpenSSL requires additional library "crypt32". Secondly, detection of pthread library failed when a cross-compiler was used (target platform is not identical to source/build platform). The "FIND_PACKAGE(Threads)" works fine but "FIND_LIBRARY(...)" either fails or finds pthread library for the wrong platform. It seems to methat presence of "CMAKE_THREAD_LIBS_INIT" which is set by the "FIND_PACKAGE(Threads)" test is a sufficiently reliable to use it to set "VMIME_HAVE_PTHREAD" but I must admit that this is not really my cup of coffee :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building for multiple platforms I encountered several issues.
Fist of all MSVC (Windows) build with TLS support through OpenSSL
requires additional library "crypt32".
Secondly, detection of pthread library failed when a cross-compiler
was used (target platform is not identical to source/build platform).
The "FIND_PACKAGE(Threads)" works fine but "FIND_LIBRARY(...)"
either fails or finds pthread library for the wrong platform.
It seems to methat presence of "CMAKE_THREAD_LIBS_INIT" which
is set by the "FIND_PACKAGE(Threads)" test is a sufficiently
reliable to use it to set "VMIME_HAVE_PTHREAD" but I must admit
that this is not really my cup of coffee :-)