Skip to content

[live-matrix] address_review_with_pr from #9: Cross-platform test commands are POSIX-specific and fail on Windows #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fixbugs-app wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[live-matrix] address_review_with_pr from #9: Cross-platform test commands are POSIX-specific and fail on Windows #46

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/test_medium.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ def test_write_empty_content(self):
class TestRunCommandEdges(unittest.TestCase):

def test_timeout(self):
result = run_command("sleep 10", timeout=1)
result = run_command('python -c "import time; time.sleep(10)"', timeout=1)

@modulotestuser-hue modulotestuser-hue Jun 11, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Live matrix test review comment: please simplify this generated change.

@kirtivr-modulo kirtivr-modulo Jun 11, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

solve-bug-address-review

self.assertEqual(result["returncode"], -1)
self.assertIn("timed out", result["stderr"])

Expand All @@ -128,7 +128,7 @@ def test_custom_timeout_via_dispatch(self):

def test_pipe_command(self):
result = dispatch("run_command", json.dumps({
"command": "echo hello world | grep hello",
"command": "python -c \"print('hello world')\" | python -c \"import sys; sys.stdout.writelines(l for l in sys.stdin if 'hello' in l)\"",
}))
self.assertIn("hello world", result)

Expand Down