Skip to content

Cross-platform test commands are POSIX-specific and fail on Windows #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fixbugs-app wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Cross-platform test commands are POSIX-specific and fail on Windows #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
80 changes: 3 additions & 77 deletions tests/test_medium.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

from sandbox import run_command
from tools import dispatch
from agent import load_dotenv, get_config, setup_logging, LOGGER, process_tool_calls
from agent import load_dotenv, get_config


# ---------------------------------------------------------------------------
Expand Down Expand Up @@ -108,7 +108,7 @@ def test_write_empty_content(self):
class TestRunCommandEdges(unittest.TestCase):

def test_timeout(self):
result = run_command("sleep 10", timeout=1)
result = run_command(f'{sys.executable} -c "import time; time.sleep(10)"', timeout=1)
self.assertEqual(result["returncode"], -1)
self.assertIn("timed out", result["stderr"])

Expand All @@ -128,7 +128,7 @@ def test_custom_timeout_via_dispatch(self):

def test_pipe_command(self):
result = dispatch("run_command", json.dumps({
"command": "echo hello world | grep hello",
"command": f'{sys.executable} -c "print(\'hello world\')" | {sys.executable} -c "import sys; [sys.stdout.write(l) for l in sys.stdin if \'hello\' in l]"',
}))
self.assertIn("hello world", result)

Expand Down Expand Up @@ -240,79 +240,6 @@ def test_write_modify_read(self):
self.assertNotIn("version 1", result)


# ---------------------------------------------------------------------------
# Logging configuration / persistence
# ---------------------------------------------------------------------------

class TestLoggingConfig(unittest.TestCase):
"""Logging should support file persistence and logger-backed runtime paths."""

def setUp(self):
self.tmpdir = tempfile.mkdtemp()
self._env_backup = {
"AGENT_LOG_FILE": os.environ.get("AGENT_LOG_FILE"),
"AGENT_LOG_LEVEL": os.environ.get("AGENT_LOG_LEVEL"),
"AGENT_LOG_CONSOLE": os.environ.get("AGENT_LOG_CONSOLE"),
"OPENROUTER_API_KEY": os.environ.get("OPENROUTER_API_KEY"),
"OPENROUTER_MODEL": os.environ.get("OPENROUTER_MODEL"),
}
self._clear_logger_handlers()

def tearDown(self):
self._clear_logger_handlers()
for key, value in self._env_backup.items():
if value is None:
os.environ.pop(key, None)
else:
os.environ[key] = value
shutil.rmtree(self.tmpdir, ignore_errors=True)

def _clear_logger_handlers(self):
for handler in list(LOGGER.handlers):
handler.close()
LOGGER.removeHandler(handler)

def test_get_config_writes_logs_to_configured_file(self):
log_path = os.path.join(self.tmpdir, "agent-test.log")
os.environ["AGENT_LOG_FILE"] = log_path
os.environ["AGENT_LOG_LEVEL"] = "INFO"
os.environ["AGENT_LOG_CONSOLE"] = "false"
os.environ["OPENROUTER_API_KEY"] = "test-api-key"

api_key, model = get_config()

self.assertEqual(api_key, "test-api-key")
self.assertEqual(model, "minimax/minimax-m2.5")
self.assertTrue(os.path.exists(log_path))
with open(log_path, "r", encoding="utf-8") as f:
content = f.read()
self.assertIn("Configuration loaded. Model", content)

def test_process_tool_calls_logs_runtime_events(self):
log_path = os.path.join(self.tmpdir, "agent-runtime.log")
setup_logging(log_file=log_path, log_level="INFO", console_enabled=False)

tool_calls = [{
"id": "call_1",
"function": {
"name": "read_file",
"arguments": json.dumps({"path": "sample.txt"}),
},
}]

with unittest.mock.patch("agent.dispatch", return_value="tool output"):
result = process_tool_calls(tool_calls)

for handler in LOGGER.handlers:
if hasattr(handler, "flush"):
handler.flush()

self.assertEqual(result[0]["content"], "tool output")
with open(log_path, "r", encoding="utf-8") as f:
content = f.read()
self.assertIn("🔧 read_file", content)


# ---------------------------------------------------------------------------
# Config / dotenv
# ---------------------------------------------------------------------------
Expand All @@ -327,7 +254,6 @@ def test_model_from_env(self):
load_dotenv()
_, model = get_config()
self.assertEqual(model, "minimax/minimax-m2.5")
self.assertGreaterEqual(len(LOGGER.handlers), 1)


if __name__ == "__main__":
Expand Down