python3 support #2

kirklg · 2016-04-29T06:17:15Z

PR to start working through python3 support.

…compatibility

…ts to assertRaises

…to assertRaises, and octal syntax

…ts to assertRaises in chown_test

wouterdebie · 2016-05-23T11:46:48Z

I'm interested in getting py3 support, but no rush. If you're prepping a PR, please continue to do so!
Thanks for the help!
On May 22, 2016 22:48, Kirk Leon Guerrero [email protected] wrote:Hi @wouterdebie,

Do you want to merge this particular commit? Or the the entire branch? I'm hoping to getting all my unstaged commits into this PR this week, but I'm fine with anything.

Thanks!

—You are receiving this because you were mentioned.Reply to this email directly or view it on GitHub

anneschuth · 2016-05-25T14:50:31Z

We're also quite interested. Our Luigi setup in Python 3 now spends a lot of time booting Hadoop just to find out HDFS targets were completed.

kirklg · 2016-06-02T16:36:46Z

Update: No updates as of yet, its been a pretty busy week and pycon didn't help :).

anneschuth · 2016-06-03T13:05:07Z

:) thanks for letting us know!

anneschuth · 2016-06-15T13:28:30Z

Hi @kirklg, don't want to rush you (really!) but I was curious whether you happened to have made any progress on this. We'll need this soon and was wondering whether you would have any (work in progress) commits I could take as a starting point ?

kirklg · 2016-06-15T16:39:38Z

Hi @anneschuth, ah! thank you so much for reminding me. Today is the day I will push some commits, standby. And thank you for the patience.

make `start_after` in `_get_dir_listing` bytes to store into reqeust.startAfter (protobuf type)

…Local`

kirklg · 2016-06-16T00:00:40Z

pushed a bunch of commits, note that the tests will fail, and I'm still working through this.

…a str

socket.error.errno is now read-only in py3 add SocketError class to assign appropriate errno values to `e` attribute.

sys.stdout.buffer exists only in python3 (emits bytes) Use sys.stdout for py2 and sys.stdout.buffer for python3

gglanzani · 2016-08-26T14:18:07Z

Hi @kirklg, I'd like to help you out on this, is there something in particular that needs to be done, or is test fixing the thing that needs to happen?

PS: Hi @anneschuth!

gglanzani · 2016-08-26T21:10:16Z

Hi @kirklg, I think the biggest issue if you get this through, will be python-krbV, which is not Python 3 compatible. Are there any tests covering Kerberos support?

kirklg · 2016-08-29T17:43:56Z

Hi @gglanzani, thank you for your comments above, please give me a few days to re-grasp :) the code I've pushed here as I've been off the grid doing other things and I really need to finish this.

As far as the python-krbV thing, I am not sure why I haven't bumped into this issue yet, probably because there is no coverage for kerberos currently in snakebite; which should be fixed ey? ;). I will go and do some research on this, also will look into python-gssapi as that is python 3 compatible.

Thanks again,

Poogles · 2016-10-04T15:58:16Z

Hi @kirklg, not wanting to push you here but have you got any further with this? We're quite keen on this and we don't want to re-invent the wheel.

If you've not got any further I may take what's been done here and start porting the rest?

Add python3.4 and 3.5 to tox setup

25c8ee9

kirklg changed the title ~~Add python3.4 and 3.5 to tox setup~~ python3 support Apr 29, 2016

kirklg added 28 commits April 28, 2016 23:21

New compat module to provide built-ins deprecated in py3

1e58347

Remove long/L suffix

90f3fb5

Import compat functions and remove python3 check

d2551d7

Import compat functions and replace xrange with range

de3da8e

Remove long compat function and replace all long types with int

8a06ad3

Add unicode compat function

fd7ca45

Replace generator method .next() with built-in next()

86fd6c2

Add code to ensure PriorityQueue gets imported on either python2 or 3

4dce9fa

Use items() over iteritems(), py2/py3 compatible

b7f5ddc

Use items() over iteritems(), py2/py3 compatible

4a87f2d

Revert request.offset back to 2/3 compatible long

e780277

Add 2/3 compatbile long type in minicluster

9e8b688

Make logger import absolute, and remove L/long prefix in ERROR_BYTES

ab19278

Replace f.func_name with f.__name__ as key string

85a4295

Make namenode import absolut, and improve import of urlparse for 2/3 …

528e250

…compatibility

Improve import of urlparse for 2/3 compatbility

e6388dd

Replace generator .next() with next built-in

4515317

Replace .has_key with "in" <dict>

b00f889

Make logger import absolute in rpc_sasl

0e9b04a

Import __future__ for python3 support

7e81dfd

Make print statements in examples be py3 print functions

4874342

Convert py2 print statement to py3 print function

c65e5c8

Make imports absolute and add 2/3 compatible range function

fcb3895

Make imports absolute and add 2/3 compatible long function

ea061db

Make imports absolute and add 2/3 compatible range function in tail_test

bf2603b

Make imports absolute and add 2/3 compatible <generator>-next argumen…

d8dd7df

…ts to assertRaises

Make imports absolute, add 2/3 compatible <generator>-next arguments …

5b627aa

…to assertRaises, and octal syntax

Make imports absolute and add 2/3 compatible <generator>-next argumen…

dac4aed

…ts to assertRaises in chown_test

kirklg added 11 commits June 15, 2016 10:29

make client_id and RPC_HEADER bytes

659ba0a

decode protobuf node.path and make bytes

2749b46

make `start_after` in `_get_dir_listing` bytes to store into reqeust.startAfter (protobuf type)

Encode return data from snakebite.client to match minicluster data

17522dd

Rename bytes to _bytes in _read_bytes, more bytes conversions

20f5d8a

make pre-data bytes and change open mode to "wb" in `_handle_copyTo…

47391a0

…Local`

py3 style exceptions and wrap filter in list to work in py3

890f7eb

make stdout.write py2/py3 compatible

a1d613b

make pre-data bytes in cat_test

cb9f93a

add py2/py3 compatible next calls in df_test

7d2ddb4

Fix tab spacing: pep8

abe0855

absolute imports in tests

3378516

kirklg added 8 commits June 16, 2016 14:33

fix typo in assertion

2c88d0d

Write bytes new line

87be290

replace py2 with py3 tox_env in travis.yml

88afc14

fix python version in .travis.yml

274af13

.message does not exist in py3, replace with .args for py2/py3

0663407

decode bytes from client to match minicluster `text', which produces …

16519d5

…a str

Fix broken tests in client_test

f1dff52

socket.error.errno is now read-only in py3 add SocketError class to assign appropriate errno values to `e` attribute.

Assign stdout alias for py2/py3

6864a5d

sys.stdout.buffer exists only in python3 (emits bytes) Use sys.stdout for py2 and sys.stdout.buffer for python3

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

python3 support #2

python3 support #2

Uh oh!

kirklg commented Apr 29, 2016

Uh oh!

wouterdebie commented May 23, 2016

Uh oh!

anneschuth commented May 25, 2016

Uh oh!

kirklg commented Jun 2, 2016

Uh oh!

anneschuth commented Jun 3, 2016

Uh oh!

anneschuth commented Jun 15, 2016

Uh oh!

kirklg commented Jun 15, 2016

Uh oh!

kirklg commented Jun 16, 2016

Uh oh!

gglanzani commented Aug 26, 2016

Uh oh!

gglanzani commented Aug 26, 2016

Uh oh!

kirklg commented Aug 29, 2016

Uh oh!

Poogles commented Oct 4, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

python3 support #2

Are you sure you want to change the base?

python3 support #2

Uh oh!

Conversation

kirklg commented Apr 29, 2016

Uh oh!

wouterdebie commented May 23, 2016

Uh oh!

anneschuth commented May 25, 2016

Uh oh!

kirklg commented Jun 2, 2016

Uh oh!

anneschuth commented Jun 3, 2016

Uh oh!

anneschuth commented Jun 15, 2016

Uh oh!

kirklg commented Jun 15, 2016

Uh oh!

kirklg commented Jun 16, 2016

Uh oh!

gglanzani commented Aug 26, 2016

Uh oh!

gglanzani commented Aug 26, 2016

Uh oh!

kirklg commented Aug 29, 2016

Uh oh!

Poogles commented Oct 4, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants