chore: fix lint failures on main (biome format)#31
Closed
kjellbergzoey wants to merge 1 commit into
Closed
Conversation
The tunnel/share + Apache-conf work landed on main without running `biome format`, so `npm run lint` (the CI lint gate) was failing on: up.tsx, restart.tsx, share.ts, BitnamiRuntimeProvider.ts, share.test.ts, agent.test.ts, mu-plugin.test.ts. Pure formatting / import-organization — no behavior changes. Restores a green lint gate for main and every open PR. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
Author
|
Folding the formatting fix into the Mailpit PR (#29) instead, per request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
mainis currently failing the lint CI gate. The recent tunnel/share + Apache-conf work was pushed without runningbiome format, leaving 7 files un-formatted:up.tsx,restart.tsx,share.ts,BitnamiRuntimeProvider.ts,share.test.ts,agent.test.ts,mu-plugin.test.ts.What
Ran
npm run format(biome check --write .). Pure formatting + import-organization — zero behavior changes.Verified
npm run lint→ clean (84 files)npm run typecheck→ passnpm test→ 224 passednpm run build→ successMerging this restores a green lint gate for main and unblocks every open PR's CI.
🤖 Generated with Claude Code