feat: simplify local hostname to <slug>.lvh.me#27
Merged
Conversation
Drop the machine-name segment from project hostnames. Since lvh.me always resolves to 127.0.0.1, the per-machine segment added nothing but noise and made URLs ugly and hard to type/rewrite. before: http://my-theme.rasmus-macbook.lvh.me:5477 after: http://my-theme.lvh.me:5477 buildProjectHostname now returns <slug>.lvh.me (and <subdomain>.<slug>.lvh.me). getMachineHostname is kept — it's still used to stamp the host on db backups. Updated hostname and status tests accordingly. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
lvh.mealways resolves to127.0.0.1, so the per-machine segment in project hostnames added no value — it just made local URLs noisy and annoying to type or copy/paste-rewrite.Change
buildProjectHostnamenow returns<slug>.lvh.me(and<subdomain>.<slug>.lvh.mefor phpMyAdmin).getMachineHostnameis kept — it's still used to record the originating host on database backups, which is legitimately useful provenance.hostnameandstatustests; dropped the now-unnecessaryos.hostnamemocking.All four gates green: lint, typecheck, 194 tests, build.
Note: the README still shows the old format — I'll update that in the pending README PR (#26) so the two stay consistent.
🤖 Generated with Claude Code