chore: adopt Biome for linting and formatting - #10
Merged
Conversation
1 task
Adds @biomejs/biome with a project config (biome.json): 2-space indent, single quotes, no bracket spacing, organize-imports, recommended lint rules (with a few project-specific rules disabled where they clash with the strict tsconfig or Ink/React patterns). Adds 'lint' and 'format' npm scripts and a dedicated lint job in CI. The large diff is the one-time 'biome check --write' format pass over the existing codebase. Two lint fixes beyond formatting: a string-concat -> template literal in db/list.tsx, and an empty destructure pattern in wp.tsx. Rebuilt on current main (post kiqr#11-kiqr#16) to resolve merge conflicts. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
kjellbergzoey
force-pushed
the
chore/adopt-biome
branch
from
June 7, 2026 08:15
c1086bc to
82a4cd0
Compare
Contributor
Author
|
Rebased onto current Now green end-to-end: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adopts Biome as the single tool for linting and formatting.
@biomejs/biomeas a devDependency and abiome.jsonconfigured for this project: TypeScript + JSX/Ink React, 2-space indentation, single quotes, ES modules, recommended linter rules, and organize-imports (Biome 2.x assist action).lint(biome check .) andformat(biome check --write .).lintjob to CI (single Node version) that runs before/alongside the existing test matrix.About the large diff
The bulk of this PR is the one-time
biome check --write .format pass applied across the whole repo. This is expected for an "adopt Biome" change. There are no behavioral changes — only formatting and import ordering.After applying,
npm run typecheck,npm test(70 passing), andnpm run buildall remain green.A note on disabled rules
A few recommended lint rules are disabled in
biome.jsonbecause they conflict with the project's existing strict tsconfig or React/Ink patterns:noNonNullAssertionanduseLiteralKeys— clash withnoUncheckedIndexedAccess/noPropertyAccessFromIndexSignaturefrom@sindresorhus/tsconfig; their autofixes would break typecheck.useExhaustiveDependenciesandnoArrayIndexKey— would require behavioral refactors of Ink components, out of scope for a formatting PR.These can be revisited in follow-ups if desired.
🤖 Generated with Claude Code