Repository navigation
Add culture Further reading to the universal set - #88
Conversation
Append five culture articles to the generic catalog and to Intentional About Culture. A reused set may keep those extra entries after the copied Amazon list.
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
An empty target list is not a prefix of extra source entries. Treat that as drift, the same as a replaced copied item.
|
@codex review |
There was a problem hiding this comment.
🟢 Approval recommended
The implementation matches the documented data model and includes focused validation coverage.
0 open findings
What changed in this PR
Adds culture-focused Further reading to the generic leadership principles set while preserving copied Amazon entries.
Changes:
- Adds five culture resources to the generic catalog and Intentional About Culture.
- Allows source sets to append reading after copied lists.
- Documents and tests the append-only behavior.
| File | Description |
|---|---|
SCHEMA.md |
Documents source-owned reading additions. |
scripts/validate.py |
Validates copied entries as an exact prefix. |
tests/test_validate.py |
Tests allowed additions and rejected drift. |
tests/test_reading.py |
Verifies culture citations and placement counts. |
data/teaching/generic/index.json |
Adds set-level culture reading. |
data/teaching/generic/intentional-about-culture.json |
Adds principle-level culture reading. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
hgl-pgm
left a comment
hgl-pgm
left a comment
There was a problem hiding this comment.
Independent review of 12256d1.
The five articles are stored the way teaching already stores Further reading: blog objects with title, url, and note. They are appended on the generic catalog (set-level) and on Intentional About Culture (the authored principle they fit). Copied Amazon lists on the other fourteen generic principles are left alone, which matches the reuse map.
_with_copied_blog requires a non-empty target prefix, so an empty Amazon list cannot be treated as "extras." Tests cover append, replaced copied items, and the empty-prefix case. Notes are one line, no em dash, no DEI.
No blocking issues.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 12256d1366
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Adds five culture articles as Further reading on the universal leadership principles set (company id
generic).They land in two places the data model already has:
data/teaching/generic/index.json, so Porridge shows them on the set page.The other fourteen generic principles keep the copied Amazon lists. These five pieces are about living a principle set as culture, so they do not get stretched onto Dive Deep or Frugality.
A reused set may now append Further reading after the copied list. Copied entries stay in step. Extra entries are the source set's own. Facet can add, remove, and edit those extras without writing them onto Amazon.