Skip to content

Show the BIQ company picker as logo tiles - #75

Merged
tig merged 4 commits into
mainfrom
company-tiles
Oct 12, 2026
Merged

tig merged 4 commits into
mainfrom
company-tiles

Conversation

@tig

@tig tig commented Oct 12, 2026 •

Copy link
Copy Markdown
Member

Replaces the BIQ company dropdown with the same always-visible logo tiles Porridge got in kindel/porridge#71.

  • Universal principles tile first, then each company in the bank. Dawn Aerospace uses the logo from https://www.dawnaerospace.com (css/logos/dawn.png), used with permission of Dawn Aerospace (Tig Kindel, owner). Porridge gets the same logo in Add the Dawn Aerospace logo to the company tiles porridge#72.
  • Radio group: one tile is always checked; arrows move and select, Home and End jump. Rust border on the checked tile; two columns on mobile.
  • Analytics unchanged: biq_company sends the same payload the dropdown did (empty for the universal set), and kld_company fires with source: "picker". ?c= behavior is unchanged.
  • Copy: "Or, you can use BIQ focused on how any of these companies define their principles." data/ui.json drops companyPlaceholder and adds universalLabel.
  • Logos are copied from kindel/porridge css/logos/ with the same licensing README. Sharing them through app-kit would mean a new mount in every host for seven small files, so a copy is simpler. On kindel.com both modules mount css to static/css, so the files land at the same path either way.
  • window.BIQ.logoBase and logos are documented in the README. If a host shell still has the old <select>, biq.js swaps it for the tile group, so merge order with kindelwww does not matter.
  • The examples page has no company picker, so it is unchanged.

@tig
tig requested a balanced review from Copilot October 12, 2026 19:50

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The picker behavior, accessibility model, compatibility path, assets, documentation, and tests are consistent and complete.

0 open findings

What changed in this PR

Replaces the company dropdown with an accessible, responsive logo-tile picker while preserving URL and analytics behavior.

Changes:

  • Adds keyboard-accessible company tiles and responsive styling.
  • Bundles seven attributed company logos with a name-only fallback.
  • Updates copy, configuration documentation, and framing tests.
File Description
js/​biq.js Implements tile rendering, selection, keyboard controls, and analytics.
css/​biq.css Styles the responsive tile grid and selected state.
index.html Replaces the dropdown with a radio group.
data/​ui.json Updates picker copy and universal label.
tests/​test_framing.py Verifies copy, markup, behavior hooks, and assets.
README.md Documents tile behavior and logo configuration.
css/​logos/​README.md Records logo sources and licensing.
css/​logos/​amazon.svg Adds the Amazon logo.
css/​logos/​arm.svg Adds the Arm logo.
css/​logos/​blue-origin.svg Adds the Blue Origin logo.
css/​logos/​coupang.svg Adds the Coupang logo.
css/​logos/​delivery-hero.svg Adds the Delivery Hero logo.
css/​logos/​gitlab.svg Adds the GitLab logo.
css/​logos/​toyota.svg Adds the Toyota logo.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@tig
tig requested a balanced review from Copilot October 12, 2026 19:57
@tig

tig commented Oct 12, 2026

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-12T20:58:52.846599Z f3a4682 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@tig

tig commented Oct 12, 2026

Copy link
Copy Markdown
Member Author

@copilot review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c3116e81b1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread js/biq.js

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The tile picker preserves existing behavior and implements the stated accessibility, responsiveness, fallback, and licensing requirements.

0 open findings

🧠 Review effort: Balanced

@tig
tig requested a balanced review from Copilot October 12, 2026 20:05
@tig

tig commented Oct 12, 2026

Copy link
Copy Markdown
Member Author

@codex review

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The picker behavior, accessibility states, compatibility path, assets, documentation, and tests are consistent and complete.

0 open findings

🧠 Review effort: Balanced

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🎉

Reviewed commit: e8d61c8609

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@tig
tig marked this pull request as ready for review October 12, 2026 20:09
@tig tig self-assigned this Oct 12, 2026
@tig
tig marked this pull request as draft October 12, 2026 20:45
@tig tig removed their assignment Oct 12, 2026
@tig
tig requested a balanced review from Copilot October 12, 2026 20:45
@tig

tig commented Oct 12, 2026

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Breezy!

Reviewed commit: f3a46821b9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Dawn is bundled and mapped despite the stated requirement that its tile remain name-only.

4 open findings

🧠 Review effort: Balanced

Comment thread css/logos/README.md
Comment thread js/biq.js
Comment thread tests/test_framing.py
Comment thread README.md
@tig
tig requested a balanced review from Copilot October 12, 2026 20:50

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The tile picker, compatibility path, accessibility behavior, assets, documentation, and tests are consistent with the stated requirements.

0 open findings

4 resolved since last review

🧠 Review effort: Balanced

@tig
tig marked this pull request as ready for review October 12, 2026 20:55
@tig tig self-assigned this Oct 12, 2026
@tig
tig merged commit 632bc74 into main Oct 12, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants