Skip to content

Record the company a BIQ visitor opens - #73

Merged
tig merged 3 commits into
mainfrom
analytics/company-usage
Oct 11, 2026
Merged

tig merged 3 commits into
mainfrom
analytics/company-usage

Conversation

@tig

@tig tig commented Oct 10, 2026 •

Copy link
Copy Markdown
Member

Record the company a visitor opens in BIQ.

biq_company, biq_level, biq_search, biq_examples_view, and biq_examples_open stay as they are. kld_company is sent as well: the company in the URL on load, a pick in the company control, and the company on the examples page. app_view fires once per load. The helper is kldTrack from kindel/app-kit.

The standalone pages pin the helper to app-kit commit 1e80086c9a4cfd40493e0ca44629fb9b96cf81f1, with subresource integrity and crossorigin="anonymous". The kindel.com page shell is in kindelwww, so the later pin on kindelwww master adds <script src="{{ "js/app-kit/analytics.js" | relURL }}" defer></script> before js/biq.js and before js/biq-examples.js, and mounts analytics.js.

No PII. No new cookies. localStorage holds company ids only, under kld-company-set. kindelwww content/privacy.md still matches this.

Merge kindel/app-kit's analytics pull request first, then this one.

Existing biq events stay. kld_company is sent as well, for the bank and for the examples page.
@tig
tig requested a balanced review from Copilot October 10, 2026 19:27
@tig

tig commented Oct 10, 2026

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The standalone pages execute an unpinned dependency from a mutable branch without subresource integrity.

2 open findings
What changed in this PR

Adds shared analytics tracking for BIQ application views and company selection.

Changes:

  • Emits app_view and kld_company events.
  • Tracks initial and picker-selected companies.
  • Loads the app-kit analytics helper on standalone pages.
File Description
js/​biq.js Adds bank and company-selection analytics.
js/​biq-examples.js Adds examples-page company analytics.
index.html Loads the shared analytics helper.
examples.html Loads the shared analytics helper.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread examples.html Outdated
Comment thread index.html Outdated
jsDelivr at main can change without a BIQ review. Both pages now load that commit with subresource integrity.
@tig

tig commented Oct 10, 2026

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@tig
tig requested a balanced review from Copilot October 10, 2026 20:51

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The event flow, script ordering, helper contract, and integrity hash are correct.

0 open findings

2 resolved since last review

🧠 Review effort: Balanced

@tig
tig requested a balanced review from Copilot October 10, 2026 21:02
@tig

tig commented Oct 10, 2026

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The event behavior, helper integration, script ordering, immutable pin, and integrity hash are consistent and correct.

0 open findings

🧠 Review effort: Balanced

@tig
tig marked this pull request as ready for review October 10, 2026 21:19
@tig tig self-assigned this Oct 10, 2026
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@tig
tig merged commit bdc4815 into main Oct 11, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants