-
Notifications
You must be signed in to change notification settings - Fork 56
Fix hidden essid error and full-width characters essid layout question #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1. 修复隐藏SSID错误问题 2. 修复中文SSID布局问题
1. Fix hidden essid error. 2. Fix Chinese essid layout question (Chinese characters will occupy two spaces lengths, one more space than regular characters) 3. Increase resource cleaning robustness.
Reviewer's GuideThis PR enhances the destructor’s cleanup to fail gracefully, ensures hidden ESSIDs are handled with a safe fallback and corrected stored checks, and adapts the ESSID column formatting to account for double-width Chinese characters by dynamically computing padding. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @wangdong0 - I've reviewed your changes and found some issues that need to be addressed.
Blocking issues:
- Padding can become negative if ESSID is long (link)
Here's what I looked at during the review
- 🔴 General issues: 1 blocking issue, 2 other issues
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
Use TruncateStr to process each field to the specified column width, ensuring that their display width is correct. Avoid using the {:<n} form of format to prevent character based padding from disrupting display width alignment.
Thanks. Merged. |
Summary by Sourcery
Fix hidden ESSID errors, improve resource cleanup robustness, and adjust ESSID column alignment to handle double-width Chinese characters
Bug Fixes:
Enhancements: