Skip to content

Fix hidden essid error and full-width characters essid layout question #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 25, 2025

Conversation

wangdong0
Copy link

@wangdong0 wangdong0 commented May 21, 2025

  1. Fix hidden essid error.
  2. Fix Chinese essid layout question (Chinese characters will occupy two spaces lengths, one more space than regular characters)
  3. Increase resource cleaning robustness.

Summary by Sourcery

Fix hidden ESSID errors, improve resource cleanup robustness, and adjust ESSID column alignment to handle double-width Chinese characters

Bug Fixes:

  • Handle missing or hidden ESSID fields to avoid key errors
  • Wrap cleanup call in destructor to suppress import, attribute, and type errors

Enhancements:

  • Dynamically adjust ESSID column width to account for double-width Chinese characters

wangdong0 added 2 commits May 20, 2025 04:09
1. 修复隐藏SSID错误问题
2. 修复中文SSID布局问题
1. Fix hidden essid error.
2. Fix Chinese essid layout question (Chinese characters will occupy two spaces lengths, one more space than regular characters)
3. Increase resource cleaning robustness.
Copy link

sourcery-ai bot commented May 21, 2025

Reviewer's Guide

This PR enhances the destructor’s cleanup to fail gracefully, ensures hidden ESSIDs are handled with a safe fallback and corrected stored checks, and adapts the ESSID column formatting to account for double-width Chinese characters by dynamically computing padding.

File-Level Changes

Change Details Files
Improve resource cleanup robustness in destructor
  • Commented out the direct cleanup() call in del
  • Wrapped cleanup() invocation in try/except catching ImportError, AttributeError, and TypeError
oneshot.py
Fix hidden ESSID handling
  • Use network.get('ESSID', 'HIDDEN') when truncating ESSID
  • Update stored-network membership check to use network.get('ESSID', '') as key
oneshot.py
Adjust ESSID column layout for Chinese characters
  • Count Chinese characters in ESSID to measure extra width
  • Compute dynamic padding as 25 − chinese_count
  • Pass the padding value into the format string for proper alignment
oneshot.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @wangdong0 - I've reviewed your changes and found some issues that need to be addressed.

Blocking issues:

  • Padding can become negative if ESSID is long (link)
Here's what I looked at during the review
  • 🔴 General issues: 1 blocking issue, 2 other issues
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

wangdong0 and others added 4 commits May 21, 2025 17:58
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
Use TruncateStr to process each field to the specified column width, ensuring that their display width is correct. Avoid using the {:<n} form of format to prevent character based padding from disrupting display width alignment.
@wangdong0 wangdong0 changed the title Fix hidden essid error and Chinese essid layout question Fix hidden essid error and full-width characters essid layout question May 21, 2025
@kimocoder kimocoder merged commit 74a9759 into kimocoder:master May 25, 2025
@kimocoder
Copy link
Owner

Thanks. Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants