Fixed syntax error in SCEst code generation for signal bodies #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t confused with local scopes
lken274
changed the title
a-sr
approved these changes
Oct 29, 2024
a-sr
changed the title
|
Build failure due to some HttpError in non critical section. Relevant checks succeeded. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#119
Because input/output signals did not create a new scope, if the first statement of the body created a scope (like a local signal or variable), then the parser assumes that scope belongs to the top level which results in a syntax error.
This commit simply adds an explicit scope to the Signal transformation.