-
Notifications
You must be signed in to change notification settings - Fork 0
[KO-572] 대체 텍스트 정리 #145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gustn99
wants to merge
20
commits into
dev
Choose a base branch
from
feat/KO-572
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[KO-572] 대체 텍스트 정리 #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… feat/KO-572 # Conflicts: # src/components/layouts/root/banner.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 내용
대체 텍스트는 스크린 리더를 통해 이미지 설명을 읽음으로써 시각장애인의 웹 접근성을 높이기 위한 용도입니다.
따라서 중복되는 정보를 제공하는 경우에는 텍스트를 제거하고, '댓글 아이콘'처럼 어색한 설명은 '댓글'과 같이 변경하는 리팩터링이 주가 되었습니다.
그 과정에서 Image 태그 대신 svgr로 변경된 내용도 다수 존재하며, 아이콘 이미지가 많은 관계로 아직 남아 있는 코드도 많이 있습니다. 해당 리팩터링 이후로 대체 텍스트 관련 표준 가이드를 정립하고, 작업하며 눈에 보이는 것들을 하나둘씩 정리하면 좋을 것 같습니다!
우선 아래 내용을 중심으로 리팩터링 진행했습니다.
ex. 랭킹 등에서: [리버풀 로고] 리버풀 -> [(공란)] 리버풀
ex. [골대 이미지] 아직 작성된 게시글이 없습니다. -> [(공란)] 아직 작성된 게시글이 없습니다.
ex. 게시글 목록 등에서: [댓글 아이콘] 23 -> [댓글] 23
관련 토스 기술 문서를 발견해서 첨부하니 참고하시면 좋을 것 같습니다!
기술 문서 1
기술 문서 2