Merged
Conversation
- Add comprehensive tests demonstrating correct BSC address generation - Clarify that Network parameter does not affect EVM address generation - Document that ExtendedPrivateKey.to_string() returns xprv/tprv format, not EVM addresses - Show that BSC mainnet and testnet use the same addresses (ChainId distinguishes them) - Add test proving Network::BitcoinMainnet and Network::BitcoinTestnet produce identical EVM addresses - Include examples of proper BSC address derivation using Bip44Signer Tests added: - crates/bip44/tests/bsc_address_test.rs - crates/khodpay-signing/tests/bsc_address_generation_test.rs This addresses confusion where users might expect different addresses for testnet when using Network::BitcoinTestnet, but EVM chains ignore the Network parameter and only use ChainId for network differentiation.
…ration-fix2 Add BSC address generation tests and documentation
- Add eip712 module: generic Eip712Type trait, Eip712Domain builder, hash/sign/verify typed data, ABI encoding helpers - Add erc4337 module: PackedUserOperation v0.7 builder, hash/sign/verify, ENTRY_POINT_V07 constant - Add 21 integration tests (PaymentIntent + UserOperation WPGP scenario) - Update lib.rs docs with module overview and quick-start examples - Update README with EIP-712 and ERC-4337 sections - Bump khodpay-signing version 0.1.0 -> 0.2.0 - Update CHANGELOG for v0.5.0
- Prefix unused sig_mainnet/sig_testnet vars with _ in bsc_address_generation_test.rs - Fix clippy::unnecessary_unwrap in bip32/src/public_key.rs (use if let Err) - Run cargo fmt --all across workspace
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.