fix: restore favicon and add frame-based animation - #240
Conversation
👷 Deploy request for finnboard0 pending review.Visit the deploys page to approve it
|
✅ Deploy Preview for finnboard ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
thanks for the fix @NiranjanRSoorej06. moving the favicon into a few things i’d like changed before merge:
|
|
@khanirfan18 , thanks for the review and the detailed feedback! I've addressed the requested changes:
The PR is now focused solely on restoring the favicon in production. Please let me know if there's anything else that needs to be updated. Thanks! |
|
thanks for the contribution! @NiranjanRSoorej06 could you remove the |
|
Hey @khanirfan18 ,thanks for the review! I've addressed the requested changes, including removing the unused public/favicon/frame_* images, and updated the PR. If everything looks good now, I'd appreciate it if you could review and merge it. Thanks again! |
Deniwn22
left a comment
There was a problem hiding this comment.
Good improvement overall. One edge case: empty string vs null aren't treated the same downstream — might need a normalization step.
kimberly-WY
left a comment
There was a problem hiding this comment.
The happy path is clean. What happens if the third-party API returns 429 here? Might be worth handling that case explicitly.
Description
This PR fixes the browser tab icon by implementing a frame-based animated favicon.
Changes Made
public/favicon/.index.htmlto correctly reference the favicon.main.jsxby cycling through PNG frames.Problem
The favicon was not displaying correctly in the browser. This implementation ensures the favicon loads properly and adds a lightweight animation for a more engaging browser tab experience.
Videos
Screen.Recording.2026-07-10.003738.mp4
Screen.Recording.2026-07-10.003657.mp4
Notes
Closes #231