Fix: Improve Reliability of Currency Exchange Rate Fetching - #227
Merged
khanirfan18 merged 1 commit intoJul 9, 2026
Merged
Conversation
…t silent failures in exchange rate updates
👷 Deploy request for finnboard0 pending review.Visit the deploys page to approve it
|
✅ Deploy Preview for finnboard ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
Author
|
@khanirfan18 Please review!! |
Contributor
Author
|
@khanirfan18 review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #226
This PR improves the robustness of the currency exchange rate fetching logic in
src/context/AppContext.jsx.Previously, the app fetched data from the external API without validating the HTTP response or ensuring the returned payload was valid. This could lead to silent failures or incorrect exchange rate data being used in the application.
Changes Made
res.okbefore processing responseWhy This Matters
Prevents silent failures in currency conversion logic
Ensures only valid exchange rate data is used in the app
Improves resilience against:
Makes debugging easier with clear error messages
Behavior Change
Testing
Impact