fix: Keep Amount as float, format to 2 decimals at UI layer - #190
Merged
khanirfan18 merged 1 commit intoJun 8, 2026
Merged
Conversation
👷 Deploy request for finnboard0 pending review.Visit the deploys page to approve it
|
✅ Deploy Preview for finnboard ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #189
This PR resolves a precision issue caused by converting transaction amounts to strings too early in the data flow. Previously, transaction amounts were formatted using
.toFixed(2)withindisplayTransactions, which converted numeric values into strings and required downstream components to repeatedly parse them back into numbers for calculations.The updated implementation preserves transaction amounts as numeric values throughout state management and calculation logic, while applying formatting only at the UI layer.
Changes
AppContext
src/context/AppContext.jsx
.toFixed(2)usage fromdisplayTransactions.convertedAmtas a raw numeric value instead of converting it to a string.UI Formatting
Moved decimal formatting to the rendering layer to preserve existing display behavior.
Updated the following components to format values with
.toFixed(2)only when rendering:src/pages/Transaction.jsxsrc/pages/Dashboard.jsxsrc/pages/Budgets.jsxsrc/pages/Goals.jsxsrc/components/CategoryBreakdown.jsxsrc/components/InsightCards.jsxBenefits
Testing