Base App and AppBridge on public core Protocol - #3
Draft
khandrew1 wants to merge 2 commits into
Draft
Conversation
@modelcontextprotocol/ext-apps
@modelcontextprotocol/server-basic-preact
@modelcontextprotocol/server-basic-react
@modelcontextprotocol/server-basic-solid
@modelcontextprotocol/server-basic-svelte
@modelcontextprotocol/server-basic-vanillajs
@modelcontextprotocol/server-basic-vue
@modelcontextprotocol/server-budget-allocator
@modelcontextprotocol/server-cohort-heatmap
@modelcontextprotocol/server-customer-segmentation
@modelcontextprotocol/server-debug
@modelcontextprotocol/server-lazy-auth
@modelcontextprotocol/server-map
@modelcontextprotocol/server-pdf
@modelcontextprotocol/server-scenario-modeler
@modelcontextprotocol/server-shadertoy
@modelcontextprotocol/server-sheet-music
@modelcontextprotocol/server-system-monitor
@modelcontextprotocol/server-threejs
@modelcontextprotocol/server-transcript
@modelcontextprotocol/server-video-resource
@modelcontextprotocol/server-wiki-explorer
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SDK dependency
Verification
Test note
The repository-wide npm test run reached 382 passes and exposed one deterministic pre-existing PDF.js range-transport assertion after a fresh dependency resolution, plus three file-watcher timeouts under concurrent load. The watcher tests pass in isolation. No PDF tests or implementation files are changed here.
Summary by cubic
Bases
AppandAppBridgeon the public@modelcontextprotocol/core/protocolengine with a unified, role-neutralProtocolWithEvents, removing the old dispatcher while keeping the lazyon*/addEventListenermodel. Aligns all examples to v2.0.0‑beta.4 and preserves the no‑MCP‑negotiation behavior on the iframe link.Refactors
App/AppBridgenow extendProtocolWithEvents(from coreProtocol); event fan-out keeps replace semantics and adds double-set protection.EventDispatcher/method-claim registry; internal guard prevents duplicate handler registration.AppBridgedepends on a structuralAppBridgeClientinterface to auto-forward MCP calls; no hard dependency on@modelcontextprotocol/client/@modelcontextprotocol/server.ui/initializeonly; no MCP version negotiation on the App↔Bridge channel (tests updated).src/mcp-types.tsto re-export protocol types; schema generation rebinds to core/protocol types to avoid TS4023; transport and React hook import from core/protocol ormcp-types.App.ping(); capability checks moved to Protocol-level asserts.Dependencies
@modelcontextprotocol/clientand@modelcontextprotocol/serverto2.0.0-beta.4; pin@modelcontextprotocol/coreviahttps://pkg.pr.new/...; mark client/server as optional peer deps.@modelcontextprotocol/core/protocol.pkg.pr.newURLs and blocks non-public registries inpackage-lock.json; lockfile regenerated with CI npm to ensure only public URLs.Written for commit ebfe660. Summary will update on new commits.