Reposition KGModal when Keyboard is present. Fixes issue #19 #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| closeFrame.origin.x = CGRectGetWidth(containerView.bounds)-CGRectGetWidth(closeFrame); | ||
| closeButton.frame = closeFrame; | ||
| } | ||
|
|
There was a problem hiding this comment.
The above calculation for right-side close button frame is done at line [141 | 222] by recalling setter. So not needed here anymore.
And furthermore, it is better to have this calculated from one place so we can update them easily (if needed) without breaking anything.
| @@ -1,41 +0,0 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
Added xccheckout file to .gitignore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a feature when you have textfield/textview in KGModal and want to reposition when keyboard appears.
This behaviour is kept optional as it is not may be an everyday use.
But when you need this behaviour, just use -
responsiveToKeyboard = YES...and you are all set!
Note: check example to see this in action.