Skip to content
This repository has been archived by the owner on Aug 6, 2024. It is now read-only.

feat: use correct pkg manager when creating keystone app #427

Closed
wants to merge 1 commit into from
Closed

feat: use correct pkg manager when creating keystone app #427

wants to merge 1 commit into from

Conversation

iamandrewluca
Copy link
Contributor

@iamandrewluca iamandrewluca commented Jan 13, 2024

Depending on what package manager tools were used, that package manager will be used.

Below package managers were tested, and are working:

  • NPM (npx, npm exec, npm init, npm create)
  • Yarn (yarn dlx, yarn create)
  • PNPm (pnpm exec, pnpm create, pnpm dlx)
  • Bun (bun create, bun init)

Closes #413

Comment on lines +50 to +55
function pkgManagerFromUserAgent(userAgent: string | undefined) {
if (!userAgent) return 'npm';
const pkgSpec = userAgent.split(' ')[0];
const [name, _version] = pkgSpec.split('/');
return name ?? 'npm';
}
Copy link
Contributor Author

@iamandrewluca iamandrewluca Jan 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iamandrewluca iamandrewluca deleted the fix/package-manager branch March 20, 2024 18:55
@dcousens
Copy link
Member

Hi @iamandrewluca,
Sorry I didn't get to reviewing this pull request.
I think I want to move this repository into https://github.com/keystonejs/keystone/ soon, as it's really difficult to keep the create-keystone-app up to date when it isn't synchronised with our monorepo.

@iamandrewluca
Copy link
Contributor Author

Hey @dcousens, I understand the pain of keeping it up to date. I'm here if you need any help from my side.

@iamandrewluca
Copy link
Contributor Author

iamandrewluca commented Apr 11, 2024

Hey @dcousens, taking into consideration what you said about create-keystone-app above, are you also considering in the future releasing all mono-repo packages under the same version to keep them all in sync?

e.g.

@keystone-6/[email protected]
@keystone-6/[email protected]

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't use yarn internally
2 participants