startup checks

[doomedraven]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @doomedraven, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the stability and diagnostic capabilities of the system by introducing robust startup checks and refining the logic for matching analysis tasks to virtual machines. It aims to prevent common configuration issues related to VM snapshots and architecture, and provides clearer feedback when tasks cannot be serviced, ultimately improving the overall reliability and user experience.

Highlights

• Enhanced VM-Task Matching Logic: Introduced a new, detailed private method _machine_can_service_task to precisely determine if a virtual machine can handle a given analysis task based on platform, architecture (x86, x64), and other tags. This includes specific rules for Windows (32-bit cannot run 64-bit tasks) and strict matching for other platforms, ensuring all non-architecture task tags are present on the machine.
• Comprehensive Startup Checks for KVM/QEMU: Added a check_snapshot_state function that runs at startup specifically for KVM/QEMU machinery. This function validates VM architecture configurations (e.g., 'x86' or 'x64', lowercase) and ensures that configured snapshots are in a 'running' state, preventing common setup errors and providing clear error messages for misconfigurations.
• Improved Error Messaging for Unserviceable Tasks: Updated the logging for CuckooUnserviceableTaskError to provide more diagnostic information. Log messages now include the task ID, whether the task is being failed or marked unserviceable, the requested tags, and the available machine tags, making it significantly easier to troubleshoot why a task cannot be serviced.
• Clarified Snapshot Restoration Error: Modified the error message when a snapshot fails to restore, explicitly stating that the snapshot 'MUST BE in running state!' to guide users towards the correct configuration.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces valuable startup checks for KVM/QEMU machinery, which will help users identify configuration issues early. The improved logging for unserviceable tasks is also a welcome addition for easier debugging. However, I've found a critical issue in lib/cuckoo/common/abstracts.py where a method was removed, which will lead to a runtime error. I've also included a minor suggestion to improve code clarity in the new startup checks.