Skip to content
This repository has been archived by the owner on May 29, 2024. It is now read-only.

Added mark for sequenced execution. Fixes #80 #107

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

norraxx
Copy link

@norraxx norraxx commented Nov 19, 2021

Added option to mark tests, that shouldn't be executed in parallel mode.

Via: #80

@alfredo-f
Copy link

I love this!

How were you able to test this new feature?

@norraxx
Copy link
Author

norraxx commented Mar 13, 2022

I've downloaded the project, checkout the branch, builded it, installed it, runned tests.

@alfredo-f
Copy link

I noticed #92 by @svetlyak40wt implemented a similar feature, and the unit test

tests/test_no_parallel.py

was added. Have you done something similar?

@norraxx
Copy link
Author

norraxx commented Mar 13, 2022

Oh I see what you're asking for. Nope :-) There is no any test for this feature. Should I add it?

@alfredo-f
Copy link

Well it would be a huge plus if you could demonstrate that the feature actually works 🚀

@norraxx
Copy link
Author

norraxx commented Mar 13, 2022

Ok, but you'll have to wait, give me some time for it. :-)

@norraxx
Copy link
Author

norraxx commented Mar 24, 2022

First of all, tests as they are in the repository are not working on python3.8.

  1. class ThreadLocalFixtureDef is fighting with pytest tmp_path_factory fixture, during the the fixture intialization phase. https://github.com/pytest-dev/pytest/blob/main/src/_pytest/fixtures.py#L1036. If I comment the line, tests will run.
  2. test_pytest_html and test_collection_collect_only are broken

Added the simple test.

@norraxx norraxx force-pushed the sequenced_execution branch from 2049b4b to 3ad9a34 Compare March 24, 2022 16:33
@norraxx norraxx force-pushed the sequenced_execution branch from 3ad9a34 to 28441a1 Compare March 24, 2022 16:34
@norraxx
Copy link
Author

norraxx commented May 4, 2022

@alfredo-f ping

@alfredo-f
Copy link

Lgtm

@norraxx
Copy link
Author

norraxx commented Jul 26, 2022

@kevlened Is this reporistory is not maintained anymore?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants