fix(linear): avoid whole-batch failure when unrelated team cache breaks - #39
Draft
cursor[bot] wants to merge 1 commit into
Draft
fix(linear): avoid whole-batch failure when unrelated team cache breaks#39cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Co-authored-by: Medhaug <Medhaug@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
linear.Tracker.BatchPushto load workflow state caches lazily per team instead of preloading every configured teamBug impact
In multi-team setups, the previous eager cache bootstrap failed the entire batch when any configured team returned an error from
TeamStates, even when no issue in the current push targeted that team. This caused complete push failures for healthy teams.Validation
CGO_ENABLED=1 go test -tags gms_pure_go ./internal/linear -run 'TestBatchPush_DoesNotFailOnUnusedBrokenTeam|TestBatchPush_PerTeamStateCache'CGO_ENABLED=1 go test -tags gms_pure_go ./internal/linearmake test(fails in this environment due existing unrelated setup issues:cmd/bdandinternal/storage/dolttests require external dependencies such asdoltbinary / host behavior)