fix(linear): restore OAuth auth in idempotent create helper - #34
Draft
cursor[bot] wants to merge 1 commit into
Draft
fix(linear): restore OAuth auth in idempotent create helper#34cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Co-authored-by: Kev Glynn <kev-pryon@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
createIssueSingleAttemptto build theAuthorizationheader viaauthHeader()instead of readingAPIKeydirectlyCreateIssueIdempotentcall pathsTestCreateIssueIdempotentOAuthUsesBearerHeaderCritical bug and impact
In OAuth-configured environments (
LINEAR_OAUTH_CLIENT_ID/LINEAR_OAUTH_CLIENT_SECRET), idempotent issue creation sent an empty/non-bearer auth header on the single-attempt mutation path. This caused deterministic 401 failures for affected create flows (notably duplicate-title single-create fallback during batch push), preventing issue creation and breaking sync/push behavior.Validation
CGO_ENABLED=1 go test -tags gms_pure_go ./internal/linear -run '^TestCreateIssueIdempotentOAuthUsesBearerHeader$'CGO_ENABLED=1 go test -tags gms_pure_go ./internal/linear -run '^TestCreateIssueIdempotent'CGO_ENABLED=1 go test -tags gms_pure_go ./internal/linear/...(Repo-wide
make testhas unrelated environment failures in this run, including missingdoltbinary in unrelated packages.)