fix(linear): prevent unrelated team outages from aborting batch push - #31
Draft
cursor[bot] wants to merge 1 commit into
Draft
fix(linear): prevent unrelated team outages from aborting batch push#31cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Co-authored-by: Kev Glynn <kev-pryon@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a high-impact batch sync regression in Linear multi-team mode.
Tracker.BatchPushwas eagerly building state caches for all configured teams before doing any work. If any secondary team had an outage or permission failure, the function returned an error andEngine.doPushaborted the entire push.Bug and impact
A,B;Bstate lookup fails (transient 5xx/auth issue); run push containing only new issues for primary teamA.BatchPushreturnedbuilding state cache for team B: ...;Engine.doPushaborted all syncing, including healthy teamAcreates.Root cause
BatchPushpreloaded state caches for everyteamIDunconditionally at function start, widening the failure domain to unrelated teams.Fix
resolveTeamCache(teamID).Tests
Added regression test:
TestBatchPush_DoesNotFailCreateWhenSecondaryTeamStateCacheFailsValidation run:
CGO_ENABLED=1 go test -tags gms_pure_go ./internal/linear/...✅make test❌ (existing environment/baseline failures unrelated to this change: missingdoltbinary and an existing cmd/bd network-behavior test failure).