fix(linear): prevent OAuth create failures and batch duplicate creates - #28
Draft
cursor[bot] wants to merge 2 commits into
Draft
fix(linear): prevent OAuth create failures and batch duplicate creates#28cursor[bot] wants to merge 2 commits into
cursor[bot] wants to merge 2 commits into
Conversation
Co-authored-by: Kev Glynn <kev-pryon@users.noreply.github.com>
Co-authored-by: Kev Glynn <kev-pryon@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes two high-severity correctness bugs in Linear sync paths introduced by recent batch/idempotency work:
OAuth idempotent create breakage
createIssueSingleAttemptsetAuthorizationdirectly fromc.APIKey, which is empty for OAuth clients.CreateIssueIdempotentpath in OAuth mode failed with unauthorized API calls.Duplicate issue creation in batch create reruns
BatchCreateIssuesonly used idempotency markers for post-failure recovery.Fixes
createIssueSingleAttemptto useauthHeader()so OAuth and API-key auth are both correct.BatchCreateIssuesbefore each batch mutation:TestCreateIssueIdempotentOAuthUsesBearerHeaderTestBatchCreateIssues_PrecheckSkipsExistingMarkersValidation
CGO_ENABLED=1 go test -tags gms_pure_go ./internal/linear -count=1 -run 'TestCreateIssueIdempotentOAuthUsesBearerHeader|TestBatchCreateIssues_PrecheckSkipsExistingMarkers|TestBatchCreateIssues_AmbiguousFailureSearchesMarkers|TestBatchPush_AmbiguousBatchFailureSearchesMarkers|TestBatchPush_BatchCreateMappingByTitle'CGO_ENABLED=1 go test -tags gms_pure_go ./internal/linear(Full
make testin this environment also reports unrelated pre-existing failures outsideinternal/linear, includingcmd/bdandinternal/storage/dolt.)