fix(linear): prevent duplicate Linear issues on batch retry - #26
Draft
cursor[bot] wants to merge 1 commit into
Draft
fix(linear): prevent duplicate Linear issues on batch retry#26cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Co-authored-by: Medhaug <Medhaug@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tracker.BatchPushbefore batching unique-title createsissueBatchCreatemutationBug and impact
A successful batch create can leave a local issue unlinked if
external_refwrite-back fails locally. On the next sync, the same issue is treated as new and re-batch-created, producing duplicate Linear issues.Root cause
Batch create path appended idempotency markers but did not check for existing markers before issuing new batch creates. Dedup checks existed for single-create but not for unique-title batch-create retries.
Fix
Perform
FindIssueByDescriptionContains(marker)for each batch-create candidate:Validation
go test -tags gms_pure_go ./internal/linear -run 'TestBatchPush_BatchCreateRetryUsesIdempotencySearch|TestBatchPush_AmbiguousBatchFailureSearchesMarkers|TestBatchPush_DuplicateTitlesFallbackToSingleCreate'go test -tags gms_pure_go ./internal/linearmake test(fails in unrelated existing tests:cmd/bd TestTestServerConnection/unreachable_hostandinternal/storage/dolt TestPullWithAutoResolve_BranchTrackingFallbackSuccessdue missingdoltexecutable in this environment)