fix(linear): avoid repeated batch updates for unchanged structured issues - #15
Draft
cursor[bot] wants to merge 1 commit into
Draft
fix(linear): avoid repeated batch updates for unchanged structured issues#15cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Co-authored-by: Kev Glynn <kev-pryon@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a critical batch-sync regression where unchanged Linear issues could be re-updated on every sync when
AcceptanceCriteria,Design, orNoteswere present.Bug + impact
When batch push receives issues whose
Descriptionwas already formatted by engine hooks, skip comparison re-ran formatting and produced a different string. This made unchanged issues look modified, causing repeated updates and avoidable rate-limit pressure that can break large sync runs.Root cause
BatchPushusedPushFieldsEqual(local, remote, ...), which always callsBuildLinearDescription(local). In batch mode,local.Descriptionmay already be pre-formatted while structured fields remain populated, so re-formatting duplicated appended sections in-memory and defeated skip detection.Fix
descriptionfield.TestBatchPush_SkipsUnchangedIssue_WithStructuredFields.Validation
CGO_ENABLED=1 go test -tags gms_pure_go ./internal/linear -run 'TestBatchPush_SkipsUnchangedIssue|TestBatchPush_SkipsUnchangedIssue_WithStructuredFields|TestBatchPush_ForceBypassesSkip'make test(fails in unrelated pre-existing environment-dependent tests incmd/bdandinternal/storage/dolt, including missingdoltbinary and existing network-assumption assertions)