Skip to content

bpf: net_sched: Fix using bpf qdisc as default qdisc #8827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: bpf-next_base
Choose a base branch
from
Open

bpf: net_sched: Fix using bpf qdisc as default qdisc #8827

wants to merge 1 commit into from
+4 −4

Conversation

kernel-patches-daemon-bpf[bot]
Copy link

Pull request for series with
subject: bpf: net_sched: Fix using bpf qdisc as default qdisc
version: 1
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=955915

@kernel-patches-daemon-bpf
Copy link
Author

Upstream branch: be2fea9
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=955915
version: 1

@kernel-patches-daemon-bpf
Copy link
Author

Upstream branch: 5cffad0
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=955915
version: 1

@kernel-patches-daemon-bpf
Copy link
Author

Upstream branch: 53ebef5
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=955915
version: 1

@kernel-patches-daemon-bpf
Copy link
Author

Upstream branch: 6aca583
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=955915
version: 1

@kernel-patches-daemon-bpf
Copy link
Author

Upstream branch: b9c09fb
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=955915
version: 1

@kernel-patches-daemon-bpf
Copy link
Author

Upstream branch: b9c09fb
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=955915
version: 1

@kernel-patches-daemon-bpf
Copy link
Author

Upstream branch: 60400cd
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=955915
version: 1

@kernel-patches-daemon-bpf
Copy link
Author

Upstream branch: 4cc2048
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=955915
version: 1

@kernel-patches-daemon-bpf
Copy link
Author

Upstream branch: 46eb012
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=955915
version: 1

@ameryhung
bpf: net_sched: Fix using bpf qdisc as default qdisc
9223a59 
Use bpf_try_module_get()/bpf_module_put() instead of try_module_get()/
module_put() when handling default qdisc since users can assign a bpf
qdisc to it.

To trigger the bug:
$ bpftool struct_ops register bpf_qdisc_fq.bpf.o /sys/fs/bpf
$ echo bpf_fq > /proc/sys/net/core/default_qdisc

Fixes: c824034 (bpf: net_sched: Support implementation of Qdisc_ops in bpf)
Signed-off-by: Amery Hung <[email protected]>
Acked-by: Cong Wang <[email protected]>
@kernel-patches-daemon-bpf
Copy link
Author

Upstream branch: 91dbac4
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=955915
version: 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bpf-next new V1-ci-pass V1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ameryhung